Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/go: go get -u subrepos #2914

Closed
bradfitz opened this issue Feb 8, 2012 · 4 comments
Closed

cmd/go: go get -u subrepos #2914

bradfitz opened this issue Feb 8, 2012 · 4 comments

Comments

@bradfitz
Copy link
Contributor

bradfitz commented Feb 8, 2012

I was under the impression that subrepos would be a little more special than they
currently are.

In particular, I'd like the go tool to understand some special label (like
"std" or "all") that expands to the subrepos at:

http://build.golang.org/packages?kind=subrepo

For instance,

$ go get -u subrepos
$ go test std subrepos

</pony>

I'm willing to do this if people are cool with it.
@rsc
Copy link
Contributor

rsc commented Feb 8, 2012

Comment 2:

I don't really want the subrepos to be very special.
We should play by the same rules everyone else does.

@bradfitz
Copy link
Contributor Author

bradfitz commented Feb 8, 2012

Comment 3:

That's fair, but I want them to be special to us in our day-to-day hacking so we know
ahead of time when we're about to break code that we as a group maintain.
I could do the previously-discussed shell script too I guess.

@rsc
Copy link
Contributor

rsc commented Feb 8, 2012

Comment 4:

I don't.  I don't want to think about them in my day-to-day
hacking - part of the point was to speed the builds -  and I am
happy to fix them after the fact.  Remember that we're not breaking
them for Go 1 users: we're breaking them for people living
at Go tip, who should expect breakages anyway.
We have a TODO to gather a collection of external code that
will form a Go 1 compatibility suite.  Maybe the right thing is
to make those the initial members of that suite.  If you had a
file listing go command package patterns, say external.txt
    code.google.com/p/go.crypto/...
    code.google.com/p/go.net/...
    &c
then external.bash can be just
    go get $(cat external.txt)
    go test $(cat external.txt)
(I plan to make patterns work in go get.)
Russ

@bradfitz
Copy link
Contributor Author

bradfitz commented Feb 8, 2012

Comment 5:

Status changed to WorkingAsIntended.

@golang golang locked and limited conversation to collaborators Jun 24, 2016
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants