Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net/http: useless string replace operation in Cookie.String #29135

Closed
bronze1man opened this issue Dec 7, 2018 · 6 comments
Closed

net/http: useless string replace operation in Cookie.String #29135

bronze1man opened this issue Dec 7, 2018 · 6 comments
Labels
FrozenDueToAge help wanted NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unplanned

Comments

@bronze1man
Copy link
Contributor

This replace operation should have no effect.So it can be delete to save cpu time and make code easier to read.
@bronze1man bronze1man changed the title [net/http] useless string replace in Cookie.String [net/http] useless string replace operation in Cookie.String Dec 7, 2018
@mvdan mvdan changed the title [net/http] useless string replace operation in Cookie.String net/http: useless string replace operation in Cookie.String Dec 7, 2018
@mvdan mvdan added the NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. label Dec 7, 2018
@mvdan
Copy link
Member

mvdan commented Dec 7, 2018

/cc @bradfitz

@mvdan
Copy link
Member

mvdan commented Jan 5, 2019

@bronze1man do you plan on sending this as a CL for 1.13? In general it should be fine to send CLs without an issue, unless there's a bug to be tracked. Otherwise, if you don't plan on sending the CL, we can just close this issue.

@bradfitz bradfitz added this to the Go1.13 milestone Jan 5, 2019
@bronze1man
Copy link
Contributor Author

Thanks for mention, I just find this bug when i read the source code.
Sorry, I do not try to send a CL at when i add the issue.
I will try to send a CL soon.

@bradfitz bradfitz modified the milestones: Go1.13, Unplanned Jan 7, 2019
@bradfitz bradfitz added help wanted NeedsFix The path to resolution is known, but the work has not been done. labels Jan 7, 2019
@gopherbot gopherbot removed the NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. label Jan 7, 2019
bronze1man added a commit to bronze1man/go that referenced this issue Jan 14, 2019
@bronze1man
net/http: useless string replace operation in Cookie.String. Fixes go…
1209770 
…lang#29135
@bronze1man bronze1man mentioned this issue Jan 14, 2019
Closed
@gopherbot
Copy link

Change https://golang.org/cl/157777 mentions this issue: net/http: useless string replace operation in Cookie.String. Fixes #29135

@bradfitz
Copy link
Contributor

Closing so I can take this over on Gerrit.

@bradfitz
Copy link
Contributor

I meant to close the PR.

@bradfitz bradfitz reopened this Apr 15, 2019
@golang golang locked and limited conversation to collaborators Apr 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge help wanted NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Unplanned
Development

Successfully merging a pull request may close this issue.

net/http: useless string replace operation in Cookie.String. Fixes #29135 bronze1man/go
4 participants
@bradfitz @bronze1man @mvdan @gopherbot