Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

What to do if you already signed the CLA

Individual signers

• It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

• Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
• The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
• The email used to register you as an authorized contributor must also be attached to your GitHub account.

I signed it!

CLAs look good, thanks!

This PR (HEAD: 578997b) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/153060 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

Message from Gobot Gobot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
Within the next week or so, a maintainer will review your change and provide
feedback. See https://golang.org/doc/contribute.html#review for more info and
tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11, it means that this CL will be reviewed as part of the next development
cycle. See https://golang.org/s/release for more details.

Please don’t reply on this GitHub thread. Visit golang.org/cl/153060.
After addressing review feedback, remember to publish your drafts!

Message from Robert Griesemer:

Patch Set 1:

LGTM as far as the change is concerned, but somebody with Windows experience should probably look at this.

Also, it would be nice to have (Windows-specific) test case. Thanks.

Please don’t reply on this GitHub thread. Visit golang.org/cl/153060.
After addressing review feedback, remember to publish your drafts!

Message from Ian Lance Taylor:

Patch Set 1:

(3 comments)

Thanks. This needs a test case.

Please don’t reply on this GitHub thread. Visit golang.org/cl/153060.
After addressing review feedback, remember to publish your drafts!

This PR (HEAD: 4ba701a) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/153060 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

This PR (HEAD: 4285b08) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/153060 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

This PR (HEAD: 03dd4ac) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/153060 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

This PR (HEAD: 20c644f) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/153060 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

Message from Alex Brainman:

Patch Set 5:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/153060.
After addressing review feedback, remember to publish your drafts!

This PR (HEAD: c460672) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/153060 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

Message from Alex Brainman:

Patch Set 6:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/153060.
After addressing review feedback, remember to publish your drafts!

This PR (HEAD: ecaff91) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/153060 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

Message from Alex Brainman:

Patch Set 7: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/153060.
After addressing review feedback, remember to publish your drafts!

Message from Gobot Gobot:

Patch Set 7:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=673d4c2a

Please don’t reply on this GitHub thread. Visit golang.org/cl/153060.
After addressing review feedback, remember to publish your drafts!

Message from Gobot Gobot:

Patch Set 7:

Build is still in progress...
This change failed on windows-amd64-2016:
See https://storage.googleapis.com/go-build-log/673d4c2a/windows-amd64-2016_aa6e4764.log

Consult https://build.golang.org/ to see whether it's a new failure. Other builds still in progress; subsequent failure notices suppressed until final report.

Please don’t reply on this GitHub thread. Visit golang.org/cl/153060.
After addressing review feedback, remember to publish your drafts!

Message from Gobot Gobot:

Patch Set 7: TryBot-Result-1

2 of 19 TryBots failed:
Failed on windows-amd64-2016: https://storage.googleapis.com/go-build-log/673d4c2a/windows-amd64-2016_aa6e4764.log
Failed on windows-386-2008: https://storage.googleapis.com/go-build-log/673d4c2a/windows-386-2008_21e7a367.log

Consult https://build.golang.org/ to see whether they are new failures.

Please don’t reply on this GitHub thread. Visit golang.org/cl/153060.
After addressing review feedback, remember to publish your drafts!

Message from Alex Brainman:

Patch Set 7:

Patch Set 7: TryBot-Result-1

2 of 19 TryBots failed:
Failed on windows-amd64-2016: https://storage.googleapis.com/go-build-log/673d4c2a/windows-amd64-2016_aa6e4764.log
Failed on windows-386-2008: https://storage.googleapis.com/go-build-log/673d4c2a/windows-386-2008_21e7a367.log

Consult https://build.golang.org/ to see whether they are new failures.

What do we do with these errors?

Alex

Please don’t reply on this GitHub thread. Visit golang.org/cl/153060.
After addressing review feedback, remember to publish your drafts!

This is only a problem in version 1.11 and has already been fixed in master.