Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go: require build cache as documented in Go 1.11 release notes #29127

Closed
bcmills opened this issue Dec 6, 2018 · 3 comments
Closed

cmd/go: require build cache as documented in Go 1.11 release notes #29127

bcmills opened this issue Dec 6, 2018 · 3 comments
Labels
FrozenDueToAge GoCommand cmd/go NeedsFix The path to resolution is known, but the work has not been done. release-blocker
Milestone
Go1.12

Comments

@bcmills
Copy link
Contributor

bcmills commented Dec 6, 2018

In https://golang.org/doc/go1.11#gocache we said:

Go 1.11 will be the last release to support setting the environment variable GOCACHE=off to disable the build cache, introduced in Go 1.10. Starting in Go 1.12, the build cache will be required, as a step toward eliminating $GOPATH/pkg.

As far as I can tell, we have not yet made the change to do that. I'll do it now.

(CC @jayconrod @rsc @andybons)
@bcmills bcmills added NeedsFix The path to resolution is known, but the work has not been done. GoCommand cmd/go release-blocker labels Dec 6, 2018
@bcmills bcmills added this to the Go1.12 milestone Dec 6, 2018
@bcmills bcmills self-assigned this Dec 6, 2018
@mark-rushakoff mark-rushakoff mentioned this issue Dec 6, 2018
Open
@gopherbot
Copy link

Change https://golang.org/cl/153462 mentions this issue: cmd/go: reject GOCACHE=off when the default cache is initialized

@gopherbot
Copy link

Change https://golang.org/cl/153637 mentions this issue: cmd/go: add a [root] condition to script_test

gopherbot pushed a commit that referenced this issue Dec 11, 2018
cmd/go: add a [root] condition to script_test
ec51004 
[root] reports whether the current effective user ID is 0.

Updates #29127

Change-Id: I9ef42f1271ea669689011e7ceff4d918c0cecb6b
Reviewed-on: https://go-review.googlesource.com/c/153637
Run-TryBot: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
@gopherbot
Copy link

Change https://golang.org/cl/188021 mentions this issue: cmd/go/internal/work: include detail in errors from cache operations

gopherbot pushed a commit that referenced this issue Sep 12, 2019
cmd/go/internal/work: include detail in errors from cache operations
1dd7164 
Since the cache has been required since Go 1.12, also remove redundant
checks for a nil cache.

Updates #29127
Updates #29667

Change-Id: Ibc59b659306a4eef2d4f0e3d0b651986d6cf84ad
Reviewed-on: https://go-review.googlesource.com/c/go/+/188021
Run-TryBot: Bryan C. Mills <bcmills@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Jay Conrod <jayconrod@google.com>
@golang golang locked and limited conversation to collaborators Jul 29, 2020
@rsc rsc unassigned bcmills Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge GoCommand cmd/go NeedsFix The path to resolution is known, but the work has not been done. release-blocker
Projects
None yet
Milestone
Go1.12
Development

No branches or pull requests
2 participants
@bcmills @gopherbot