Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

builders: misc-vet-vetall flakes: undefined: importer.ForCompiler #29116

Closed
mdempsky opened this issue Dec 5, 2018 · 2 comments
Closed

builders: misc-vet-vetall flakes: undefined: importer.ForCompiler #29116

mdempsky opened this issue Dec 5, 2018 · 2 comments
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge

Comments

@mdempsky
Copy link
Member

mdempsky commented Dec 5, 2018

I've trybotted golang.org/cl/152544 three times, and twice it gave the same misc-vet-vetall failure:

##### cmd/vet/all
# golang.org/x/tools/go/analysis/unitchecker
../../gopath/src/golang.org/x/tools/go/analysis/unitchecker/unitchecker112.go:8:24: undefined: importer.ForCompiler
vet/all: exit status 2

https://storage.googleapis.com/go-build-log/5004c83e/misc-vet-vetall_2594bb0d.log
https://storage.googleapis.com/go-build-log/0ce4e24a/misc-vet-vetall_d4638ddb.log

I'm pretty sure these failures are unrelated to the CL, so maybe the trybot is broken?

/cc @bradfitz

@mdempsky mdempsky added the Builders x/build issues (builders, bots, dashboards) label Dec 5, 2018
@ianlancetaylor
Copy link
Contributor

The importer.ForCompiler function was added yesterday in https://golang.org/cl/152258. The vet test runs go build golang.org/x/tools/go/analysis/cmd/vet. Is it possible that your sources do not have importer.ForCompiler but the builder does have an up to date golang.org/x/tools? That is, do you just need to git codereview sync?

@mdempsky
Copy link
Member Author

mdempsky commented Dec 5, 2018

Is it possible that your sources do not have importer.ForCompiler but the builder does have an up to date golang.org/x/tools?

Oh, yes, I think that's probably it.

PS1 had the failure; PS2 (PS1 rebased at master) did not have it; but then I uploaded PS1 with tweaks (and without rebasing locally) as PS3 and had the failure again.

Thanks, sorry for the noise.

@mdempsky mdempsky closed this as completed Dec 5, 2018
@golang golang locked and limited conversation to collaborators Dec 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge
Projects
None yet
Development

No branches or pull requests

3 participants