New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
runtime: TestAbort fails with "panic: BAD: recovered from abort" on windows/arm #29050
Comments
On UNIX systems, this just triggers SIGSEGV and the runtime's
The assembly code seems ok to me, matching the runtime's check. On Windows, function
I'm not familiar with Windows, but I suspect the |
Change https://golang.org/cl/152357 mentions this issue: |
Thank you for finger pointing. Hopefully, I did not misinterpret your explanation https://go-review.googlesource.com/c/go/+/152357 Alex |
Looks like the fix worked:
Before the fix:
|
Thanks for checking. I will wait for codereview on https://go-review.googlesource.com/c/go/+/152357 now. Alex |
windows/arm builder fails
https://build.golang.org/log/dcf35b2e42a6d30ca1d7604ce79d5c50e8071b04
on runtime.TestAbort test with
runtime.TestAbort runs Abort function
go/src/runtime/testdata/testprog/abort.go
Lines 13 to 23 in f70bd91
As far as I can tell, process containing Abort is suppose to exit at line 18. But windows/arm seems to continue to line 19.
runtime.abort is just a INT $3 on amd64, but on arm it looks like this
go/src/runtime/asm_arm.s
Lines 799 to 801 in f70bd91
Perhaps this code hits exception handler on Windows, where things recover. If that is so, what code should we put into runtime.abort, so it does not recover?
@jordanrh1 please help.
Thank you.
Alex
The text was updated successfully, but these errors were encountered: