Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go/packages: support file= queries against overlay files #29048

Closed
ianthehat opened this issue Nov 30, 2018 · 1 comment
Closed

go/packages: support file= queries against overlay files #29048

ianthehat opened this issue Nov 30, 2018 · 1 comment
Labels
FeatureRequest FrozenDueToAge

Comments

@ianthehat
Copy link

As of cl/151999 we support adding new files in the overlay.
It is highly likely that any file that was added in an overlay is also going to be used in file= queries, as that is what all the editor tools will be doing.
At the moment we check the results of go list for a package that contains the file, which will not have any of the overlay files in it, it should be fairly easy to do that check after the overlay additions instead of before, to enable this use case.
@gopherbot
Copy link

Change https://golang.org/cl/152797 mentions this issue: go/packages: check for containing files after overlay is processed

@golang golang locked and limited conversation to collaborators Dec 6, 2019
@rsc rsc unassigned matloob Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FeatureRequest FrozenDueToAge
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ianthehat @gopherbot @matloob