Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build/maintner: Add Ability to Add GitHub and Gerrit Repositories while in SyncLoop #29042

Open
orthros opened this issue Nov 30, 2018 · 1 comment
Open

x/build/maintner: Add Ability to Add GitHub and Gerrit Repositories while in SyncLoop #29042

orthros opened this issue Nov 30, 2018 · 1 comment
Labels
Builders x/build issues (builders, bots, dashboards)
Milestone
Unreleased

Comments

@orthros
Copy link

orthros commented Nov 30, 2018

Currently if you call SyncLoop in a goroutine, and later call TrackGitHub or TrackGerrit, the corpus will not actually track that repository until the sync method returns and SyncLoop is called again.

This means that users of corpus that wish to add repositories to track on the fly need to maintain a custom written loop and call Sync.
@gopherbot gopherbot added this to the Unreleased milestone Nov 30, 2018
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Nov 30, 2018
@gopherbot
Copy link

Change https://golang.org/cl/152017 mentions this issue: maintner: corpus can now add GitHub and Gerrit repos while in SyncLoop

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards)
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
2 participants
@orthros @gopherbot