Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/go: TestExecBuildX is too sensitive to GOROOT #29004

Closed
bcmills opened this issue Nov 29, 2018 · 1 comment
Closed

cmd/go: TestExecBuildX is too sensitive to GOROOT #29004

bcmills opened this issue Nov 29, 2018 · 1 comment
Labels
FrozenDueToAge GoCommand cmd/go NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone

Comments

@bcmills
Copy link
Contributor

bcmills commented Nov 29, 2018

When making changes to cmd/go (and not other parts of the standard library or toolchain), most of the test cases in go test cmd/go continue to pass without rebuilding. However, TestExecBuildX seems to fail pretty reliably unless make.bash has been run at the exact commit being tested.

That's a bit annoying, because make.bash itself is pretty slow. I'd like to figure out whether we can make TestExecBuildX more robust to changes.

@bcmills bcmills added Testing An issue that has been verified to require only test changes, not just a test failure. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. GoCommand cmd/go labels Nov 29, 2018
@bcmills bcmills added this to the Go1.13 milestone Nov 29, 2018
@bcmills bcmills self-assigned this Nov 29, 2018
@gopherbot
Copy link

Change https://golang.org/cl/183838 mentions this issue: cmd/go: ensure that runtime/cgo is not stale in TestExecBUildX

@golang golang locked and limited conversation to collaborators Jun 24, 2020
@rsc rsc unassigned bcmills Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge GoCommand cmd/go NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Development

No branches or pull requests

2 participants