Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plugin: TestPlugin fails on linux/arm64 #28982

Closed
alexbrainman opened this issue Nov 28, 2018 · 2 comments
Closed

plugin: TestPlugin fails on linux/arm64 #28982

alexbrainman opened this issue Nov 28, 2018 · 2 comments
Labels
FrozenDueToAge

Comments

@alexbrainman
Copy link
Member

linux/arm64 builder is broken

https://build.golang.org/log/2eb7494571c1d6ebc6d8308c6bab8daec7e2a509

with

# plugin.test
/workdir/go/pkg/tool/linux_arm64/link: running gcc failed: exit status 1
/usr/bin/ld.gold: internal error in global, at ../../gold/aarch64.cc:4973
collect2: error: ld returned 1 exit status

ok  	path/filepath	0.083s
FAIL	plugin [build failed]

https://go-review.googlesource.com/c/go/+/151478 was suppose to fix the failure, but it did not fix it. I don't see what the problem is.

Need help.

Thank you.

Alex
@tklauser
Copy link
Member

I think the build constraint is wrong. Currently it is

// +build !nacl !linux,arm64

which corresponds to

!nacl OR (!linux AND arm64)

which is still satisfied by linux/arm64.

Instead it should be

// +build !nacl
// +build !linux linux,!arm64

which corresponds to

!nacl AND (!linux OR (linux AND !arm64))

@gopherbot
Copy link

Change https://golang.org/cl/151303 mentions this issue: plugin: fix build constraint to disable test on linux/arm64

@golang golang locked and limited conversation to collaborators Nov 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tklauser @gopherbot @alexbrainman