Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/fix: camlistore file fails to parse in go fix #2898

Closed
bradfitz opened this issue Feb 7, 2012 · 2 comments
Closed

cmd/fix: camlistore file fails to parse in go fix #2898

bradfitz opened this issue Feb 7, 2012 · 2 comments
Milestone

Comments

@bradfitz
Copy link
Contributor

bradfitz commented Feb 7, 2012

$ go version
go version weekly.2012-01-27 +82bac8cdab6b

$ go fix .
camlistored.go:90:49: expected '}', found newline
camlistored.go:93:15: expected ';', found ':'
camlistored.go:94:11: illegal label declaration
camlistored.go:95:2: expected operand, found '}'

File (valid from r60) is attached.

Line 90 is the NotAfter line here, ending in a trailing comment:

        template := x509.Certificate{
                SerialNumber: new(big.Int).SetInt64(0),
                Subject: pkix.Name{
                        CommonName:   hostname,
                        Organization: []string{hostname},
                },
                NotBefore: time.SecondsToUTC(now - 300),
                NotAfter:  time.SecondsToUTC(now + 60*60*24*365), // valid for 1 year.                            

                SubjectKeyId: []byte{1, 2, 3, 4},
                KeyUsage:     x509.KeyUsageKeyEncipherment | x509.KeyUsageDigitalSignature,
        }

Assuming this is a go/ast thing, so passing it first to Robert.

Attachments:

  1. camlistored.go (5021 bytes)
@griesemer
Copy link
Contributor

Comment 1:

hg clpatch 5598054 (review pending)
and try again. If it goes away then this is a duplicate of issue #1505.

@griesemer
Copy link
Contributor

Comment 2:

Verified that the issue goes away with pending CL 5598054:
go tool fix camlistored.go 
camlistored.go: fixed error time+fileinfo
This is a duplicate of issue #1505.

Status changed to Duplicate.

Merged into issue #1505.

@rsc rsc added this to the Go1 milestone Apr 10, 2015
@rsc rsc removed the priority-go1 label Apr 10, 2015
@golang golang locked and limited conversation to collaborators Jun 24, 2016
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants