This PR (HEAD: d8a6d0f) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/151323 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

Message from Gergely Brautigam:

Patch Set 1:

Hi!

I need some further guidance on how to handle the error testcase and how to test for compiler output.

I was looking at issue22662b.go which if I understand correctly checks the compiler's output? Is that correct? Is there another sample I could look at?

Also, right now the solution looks like this:

❯ go tool compile main.go
main.go:8:7: undefined: G
main.go:11:7: undefined: E
main.go:14:2: undefined: asdf

With code like this:

package main

var t int

func main() {
var e interface{}
switch e := e.(type) {
case G:
e.M()
asdf
case E:
e.D()
}
asdf
}

Is this okay?

Thanks,
Gergely.

Please don’t reply on this GitHub thread. Visit golang.org/cl/151323.
After addressing review feedback, remember to publish your drafts!

This PR (HEAD: 8a29aaf) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/151323 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

This PR (HEAD: 62ba0a4) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/151323 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

This PR (HEAD: 6c78929) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/151323 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

Message from Kale Blankenship:

Patch Set 6: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/151323.
After addressing review feedback, remember to publish your drafts!

Message from Gobot Gobot:

Patch Set 6:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=cfa0c444

Please don’t reply on this GitHub thread. Visit golang.org/cl/151323.
After addressing review feedback, remember to publish your drafts!

Message from Gobot Gobot:

Patch Set 6:

Build is still in progress...
This change failed on misc-vet-vetall:
See https://storage.googleapis.com/go-build-log/cfa0c444/misc-vet-vetall_d09767c3.log

Consult https://build.golang.org/ to see whether it's a new failure. Other builds still in progress; subsequent failure notices suppressed until final report.

Please don’t reply on this GitHub thread. Visit golang.org/cl/151323.
After addressing review feedback, remember to publish your drafts!

Message from Gobot Gobot:

Patch Set 6: TryBot-Result-1

1 of 19 TryBots failed:
Failed on misc-vet-vetall: https://storage.googleapis.com/go-build-log/cfa0c444/misc-vet-vetall_d09767c3.log

Consult https://build.golang.org/ to see whether they are new failures.

Please don’t reply on this GitHub thread. Visit golang.org/cl/151323.
After addressing review feedback, remember to publish your drafts!

Message from Kale Blankenship:

Patch Set 6:

Doesn't seem like the vet failure is related to this change. Perhaps someone else can advise on that.

Please don’t reply on this GitHub thread. Visit golang.org/cl/151323.
After addressing review feedback, remember to publish your drafts!

Message from Ian Lance Taylor:

Patch Set 6:

Doesn't seem like the vet failure is related to this change. Perhaps someone else can advise on that.

The vet error should go away if you rebase to tip.

Please don’t reply on this GitHub thread. Visit golang.org/cl/151323.
After addressing review feedback, remember to publish your drafts!

This PR (HEAD: 03c62d5) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/151323 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

Message from Kale Blankenship:

Patch Set 7: Run-TryBot+1

Patch Set 6: TryBot-Result-1

1 of 19 TryBots failed:
Failed on misc-vet-vetall: https://storage.googleapis.com/go-build-log/cfa0c444/misc-vet-vetall_d09767c3.log

Consult https://build.golang.org/ to see whether they are new failures.

Please don’t reply on this GitHub thread. Visit golang.org/cl/151323.
After addressing review feedback, remember to publish your drafts!

Message from Gobot Gobot:

Patch Set 7:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=63f48957

Please don’t reply on this GitHub thread. Visit golang.org/cl/151323.
After addressing review feedback, remember to publish your drafts!

Message from Gobot Gobot:

Patch Set 7: TryBot-Result+1

TryBots are happy.

Please don’t reply on this GitHub thread. Visit golang.org/cl/151323.
After addressing review feedback, remember to publish your drafts!

Message from Gergely Brautigam:

Patch Set 7:

Patch Set 7: TryBot-Result+1

TryBots are happy.

I hope you'll still be able to cherry pick this. I had to nuke my Go fork. :/ Now it's saying unknown repository as source. :/

If this doesn't work, I'm happy to open another one.

Please don’t reply on this GitHub thread. Visit golang.org/cl/151323.
After addressing review feedback, remember to publish your drafts!

Message from Brad Fitzpatrick:

Patch Set 7:

Patch Set 7:

Patch Set 7: TryBot-Result+1

TryBots are happy.

I hope you'll still be able to cherry pick this. I had to nuke my Go fork. :/ Now it's saying unknown repository as source. :/

git fetch https://go.googlesource.com/go refs/changes/23/151323/7 && git cherry-pick FETCH_HEAD

If this doesn't work, I'm happy to open another one.

Please just keep using this Change-Id.

Please don’t reply on this GitHub thread. Visit golang.org/cl/151323.
After addressing review feedback, remember to publish your drafts!

Message from Gergely Brautigam:

Patch Set 7:

Please just keep using this Change-Id.

Cool! Thanks Brad!

Please don’t reply on this GitHub thread. Visit golang.org/cl/151323.
After addressing review feedback, remember to publish your drafts!

Message from Josh Bleecher Snyder:

Patch Set 7:

(6 comments)

Looks to me like this is on the right track. Lots of little comments.

My apologies again for the very slow review time. Speedy reviews are critical to the health of the contributor community.

Please don’t reply on this GitHub thread. Visit golang.org/cl/151323.
After addressing review feedback, remember to publish your drafts!

Message from Gergely Brautigam:

Patch Set 7:

Patch Set 7:

(6 comments)

Looks to me like this is on the right track. Lots of little comments.

My apologies again for the very slow review time. Speedy reviews are critical to the health of the contributor community.

Thanks! No worries! :) I'll address them as soon as I can. :)

Please don’t reply on this GitHub thread. Visit golang.org/cl/151323.
After addressing review feedback, remember to publish your drafts!