Skip to content

strconv: intermittent test failure #2894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
alberts opened this issue Feb 7, 2012 · 7 comments
Closed

strconv: intermittent test failure #2894

alberts opened this issue Feb 7, 2012 · 7 comments
Labels
FrozenDueToAge
Milestone
Go1

Comments

@alberts
Copy link
Contributor

alberts commented Feb 7, 2012 

What steps will reproduce the problem?
1. ./make.bash

What do you see instead?

--- FAIL: TestAppendUintDoesntAllocate-16 (0.00 seconds)
itoa_test.go:146: with local buffer, did 7 allocations, want 1
FAIL
FAIL strconv 0.057s

Which compiler are you using (5g, 6g, 8g, gccgo)?

6g

Which operating system are you using?

linux

Which revision are you using?  (hg identify)

tip

Please provide any additional information below.

happens rarely

https://groups.google.com/group/golang-dev/browse_thread/thread/bd6731294a924075
@remyoudompheng
Copy link
Contributor

Comment 1:

Could that be caused by parallel tests?

@alberts
Copy link
Contributor Author

alberts commented Feb 8, 2012

Comment 2:

Possible. Could also be related to issue #2917?

@remyoudompheng
Copy link
Contributor

Comment 3:

I think issue #2917 is a real bug in the code: it happens rarely because the test chooses
random inputs and is not reproducible (is that allowed?).

@alberts
Copy link
Contributor Author

alberts commented Feb 8, 2012

Comment 4:

Okay. BTW, we solved that problem in the gob fuzz tests by seeding the RNG with the
current time and logging the seed.

@rsc
Copy link
Contributor

rsc commented Feb 8, 2012

Comment 5:

I suspect this allocation count is just a bug in the test.
I suspect the strconv case is real.  We don't need to log
the random seed or anything like that, because the error
prints enough information to verify the claim (the relevant number).
Russ

@robpike
Copy link
Contributor

robpike commented Feb 11, 2012

Comment 6:

Labels changed: added priority-go1, removed priority-triage.

Owner changed to builder@golang.org.

Status changed to Accepted.

@rsc
Copy link
Contributor

rsc commented Feb 20, 2012

Comment 7:

This issue was closed by revision a533176.

Status changed to Fixed.

@rsc rsc added this to the Go1 milestone Apr 10, 2015
@rsc rsc removed the priority-go1 label Apr 10, 2015
@golang golang locked and limited conversation to collaborators Jun 24, 2016
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Go1
Development

No branches or pull requests
5 participants
@rsc @remyoudompheng @alberts @robpike @gopherbot