Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net/http: spelling mistake in a comment #28904

Closed
haormj opened this issue Nov 21, 2018 · 2 comments
Closed

net/http: spelling mistake in a comment #28904

haormj opened this issue Nov 21, 2018 · 2 comments
Labels
FrozenDueToAge

Comments

@haormj
Copy link

haormj commented Nov 21, 2018

go/src/net/http/transport.go

Line 2419 in ae65615

// clneTLSConfig returns a shallow clone of cfg, or a new zero tls.Config if

expected: cloneTLSConfig
actually: clneTLSConfig
@mvdan mvdan changed the title spelling mistake net/http: spelling mistake in a comment Nov 21, 2018
@mvdan
Copy link
Member

mvdan commented Nov 21, 2018

@haormj why not just send a CL or PR? See https://golang.org/doc/contribute.html

haormj added a commit to haormj/go that referenced this issue Nov 21, 2018
@haormj
net/http: spelling mistake in a comment
3a7865a 
Fixes golang#28904
@haormj haormj mentioned this issue Nov 21, 2018
Closed
@gopherbot
Copy link

Change https://golang.org/cl/150737 mentions this issue: net/http: spelling mistake in a comment

bradfitz pushed a commit that referenced this issue Nov 21, 2018
@haormj @mvdan
net/http: fix spelling mistake in a comment
4a8ce14 
Fixes #28904

Change-Id: I8d416c47479a266735a39c926fd2f0f2bb25d57b
GitHub-Last-Rev: 3a7865a
GitHub-Pull-Request: #28907
Reviewed-on: https://go-review.googlesource.com/c/150737
Reviewed-by: Daniel Martí <mvdan@mvdan.cc>
Run-TryBot: Daniel Martí <mvdan@mvdan.cc>
TryBot-Result: Gobot Gobot <gobot@golang.org>
@golang golang locked and limited conversation to collaborators Nov 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mvdan @gopherbot @haormj