Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build/cmd/coordinator: subrepo trybot on branches should use corresponding Go branch only #28891

Closed
bradfitz opened this issue Nov 20, 2018 · 5 comments
Closed

x/build/cmd/coordinator: subrepo trybot on branches should use corresponding Go branch only #28891

bradfitz opened this issue Nov 20, 2018 · 5 comments
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unreleased

Comments

@bradfitz
Copy link
Contributor

I tried to run trybots on an an x/tools CL https://go-review.googlesource.com/c/tools/+/150577 but the CL was on release-branch.go1.11

It then failed on the trybots because:

https://storage.googleapis.com/go-build-log/b44cd154/linux-amd64_f19d5954.log

linux-amd64 at b44cd15464a87be57446a7573f76846088826606 building tools at 9d66f1bfdbed72f546df963194a19d56180c4ce7
....

That b44cd15 is the current HEAD of master. It should use the "go" repo's "release-branch.go1.11".

/cc @dmitshur
@bradfitz bradfitz added the NeedsFix The path to resolution is known, but the work has not been done. label Nov 20, 2018
@gopherbot gopherbot added this to the Unreleased milestone Nov 20, 2018
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Nov 20, 2018
@bradfitz
Copy link
Contributor Author

This strikes again:
https://go-review.googlesource.com/c/net/+/154237/1#message-554c707ebc6362aff8d7b17d4b1a5efbcebbd471

/cc @andybons

@bradfitz
Copy link
Contributor Author

And again:
https://go-review.googlesource.com/c/tools/+/163780

/cc @dmitshur

@bradfitz
Copy link
Contributor Author

And again:
https://go-review.googlesource.com/c/tools/+/164657

@bradfitz
Copy link
Contributor Author

Debugging. For that last one,

$ maintq try-work
waiting:<
project:"tools"
branch:"release-branch.go1.12" 
change_id:"Id78454bb6a51b3c5e1bcb1984a7fbfb4a29a5be0"
commit:"a8ab5f379ee650184c0b314a1e70c1c822f2c8d9"
go_commit:"0a04c0430e9671bd531a2928a8416424da1e3dde"
go_commit:"7e880151b1763ebe608d7c2cadf36b71f184332a"
go_commit:"8390781ca35ac5874eb5b136cfc29bb47adee94b"
go_branch:"master"
go_branch:"release-branch.go1.12"
go_branch:"release-branch.go1.11"
go_version:<major:1 minor:12 >
go_version:<major:1 minor:12 >
go_version:<major:1 minor:11 > >

@gopherbot
Copy link

Change https://golang.org/cl/167382 mentions this issue: cmd/coordinator: run release branch subrepo trybots on corresponding Go branch

@golang golang locked and limited conversation to collaborators Mar 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
2 participants
@bradfitz @gopherbot