Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/net/ipv{4,6}: WriteBatch run for loop in non-linux OS case #28859

Closed
rmzg opened this issue Nov 18, 2018 · 1 comment
Closed

x/net/ipv{4,6}: WriteBatch run for loop in non-linux OS case #28859

rmzg opened this issue Nov 18, 2018 · 1 comment
Labels
FrozenDueToAge
Milestone
Unreleased

Comments

@rmzg
Copy link

rmzg commented Nov 18, 2018

In https://github.com/golang/net/blob/master/ipv4/batch.go#L170 there is a switch on OS with a branch for Linux, which uses the sendmmsg syscall and a default branch which just sends the first message ms[0] via the standard go SendMsg function.

Can the default (non-linux) route be changed to instead run a for loop over []ms and thus send all of them and mimic the behaviour of the linux version?
@gopherbot gopherbot added this to the Unreleased milestone Nov 18, 2018
@rmzg rmzg closed this as completed Nov 18, 2018
@rmzg
Copy link
Author

rmzg commented Nov 18, 2018

Never mind, I misunderstood the API here.

@mikioh mikioh changed the title x/net: WriteBatch run for loop in non-linux OS case x/net/ipv{4,6}: WriteBatch run for loop in non-linux OS case Nov 18, 2018
@golang golang locked and limited conversation to collaborators Nov 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
2 participants
@rmzg @gopherbot