Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build/cmd/gerritbot: copy abandon message to PR #28855

Closed
FiloSottile opened this issue Nov 18, 2018 · 2 comments
Closed

x/build/cmd/gerritbot: copy abandon message to PR #28855

FiloSottile opened this issue Nov 18, 2018 · 2 comments
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge help wanted NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unreleased

Comments

@FiloSottile
Copy link
Contributor

When gerritbot closes a PR due to the Gerrit CL being abandoned, it should copy the message of the abandon step. There's often some rationale offered by whoever is abandoning it, and it should be provided to the GitHub user.

This especially happens with new contributors who are not aware of Gerrit, and who might have their CL abandoned for some reason like a proposal being declined. It's not nice to have them see their PR closed without explanation.

For example: #28851 (comment)
@gopherbot gopherbot added this to the Unreleased milestone Nov 18, 2018
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Nov 18, 2018
@FiloSottile FiloSottile added help wanted NeedsFix The path to resolution is known, but the work has not been done. labels Nov 18, 2018
@gopherbot
Copy link

Change https://golang.org/cl/150817 mentions this issue: x/build/cmd/gerritbot: sync abandon message to PR

@dmitshur dmitshur mentioned this issue Jan 12, 2019
Closed
@dmitshur
Copy link
Contributor

I've deployed and confirmed it works. You can see an example of an abandon message from Gerrit being copied to the original Pull Request here:

golang/scratch#34 (comment)

Thank you @oiooj for helping resolve this!

@golang golang locked and limited conversation to collaborators Jan 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge help wanted NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@FiloSottile @dmitshur @gopherbot