Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/compile: function ABIs broke TestNexting #28787

Closed
aclements opened this issue Nov 14, 2018 · 7 comments
Closed

cmd/compile: function ABIs broke TestNexting #28787

aclements opened this issue Nov 14, 2018 · 7 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker
Milestone

Comments

@aclements
Copy link
Member

CL 147160 broke TestNesting. For example, https://build.golang.org/log/32264b507240ee2701ccd300c01463e1968f98bf

@dr2chase, is there anything obvious that would have caused this failure?

@aclements aclements added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker labels Nov 14, 2018
@aclements aclements added this to the Go1.12 milestone Nov 14, 2018
@dr2chase
Copy link
Contributor

It happens somewhere after the compiler, so officially not obvious.

@dr2chase
Copy link
Contributor

My working hypothesis is that something goes wrong here:

		pciterinit(ctxt, &pcstmt, &sym.Pcdata{P: s.FuncInfo.IsStmtSym.P})

		if pcstmt.done != 0 {
			// Assembly files lack a pcstmt section, we assume that every instruction
			// is a valid statement.
			pcstmt.value = 1
		}

in cmd/link/internal/ld/dwarf.go
The iterator is empty, so is_stmt is always true.

@aclements
Copy link
Member Author

Thanks. I suspect where that's going wrong is

		s.FuncInfo.IsStmtSym = r.syms.Lookup(dwarf.IsStmtPrefix+s.Name, int(s.Version))

in objReader.readSym. The IsStmt symbol is probably always declared as version 0, but s.Version may be 1 now for an ABIInternal symbol.

@dr2chase
Copy link
Contributor

This was fixed by https://go-review.googlesource.com/c/go/+/149605
and I can confirm this by my failure to reproduce the bug now.

@katiehockman
Copy link
Contributor

This appears to be failing again for linux-amd64-longtest.

Latest failure: https://build.golang.org/log/ad327f4df87dc312a4840aa82dccbaf832822120

@katiehockman katiehockman reopened this Jan 2, 2019
@FiloSottile
Copy link
Contributor

@dr2chase Can you look into this and let us know if it should still be a release blocker?

@aclements
Copy link
Member Author

It appears the latest breakage is from CL 152537, which is unrelated to function ABIs. I've moved this into a new issue: #29511.

@golang golang locked and limited conversation to collaborators Jan 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker
Projects
None yet
Development

No branches or pull requests

5 participants