Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

testing: add Write method to T and B #28777

Closed
wants to merge 1 commit into from
Closed

testing: add Write method to T and B #28777

wants to merge 1 commit into from

Conversation

poy
Copy link
Contributor

@poy poy commented Nov 13, 2018

T and B implement io.Writer so that each can be used to create a logger.

Fixes #22513

This PR will be imported into Gerrit with the title and first
comment (this text) used to generate the subject and body of
the Gerrit change.

Please ensure you adhere to every item in this list.

More info can be found at https://github.com/golang/go/wiki/CommitMessage

  • The PR title is formatted as follows: net/http: frob the quux before blarfing
    • The package name goes before the colon
    • The part after the colon uses the verb tense + phrase that completes the blank in,
      "This change modifies Go to ___________"
    • Lowercase verb after the colon
    • No trailing period
    • Keep the title as short as possible. ideally under 76 characters or shorter
  • No Markdown
  • The first PR comment (this one) is wrapped at 76 characters, unless it's
    really needed (ASCII art, table, or long link)
  • If there is a corresponding issue, add either Fixes #1234 or Updates #1234
    (the latter if this is not a complete fix) to this comment
  • If referring to a repo other than golang/go you can use the
    owner/repo#issue_number syntax: Fixes golang/tools#1234
  • We do not use Signed-off-by lines in Go. Please don't add them.
    Our Gerrit server & GitHub bots enforce CLA compliance instead.
  • Delete these instructions once you have read and applied them

@poy
testing: add Write method to T and B
2fea5c0 
T and B implement io.Writer so that each can be used to create a logger.

Fixes golang#22513
@googlebot googlebot added the cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. label Nov 13, 2018
@gopherbot
Copy link

This PR (HEAD: 2fea5c0) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/149379 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link

Message from Gobot Gobot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
Within the next week or so, a maintainer will review your change and provide
feedback. See https://golang.org/doc/contribute.html#review for more info and
tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11, it means that this CL will be reviewed as part of the next development
cycle. See https://golang.org/s/release for more details.

Please don’t reply on this GitHub thread. Visit golang.org/cl/149379.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Sam Whited:

Patch Set 1:

(3 comments)

API changes generally need a full proposal, and the issue you're fixing was closed so I don't think this will be merged (though you'll have to wait for someone with +2 rights to make the final call on that), but I've included a few comments for future reference. Thanks for contributing!

Please don’t reply on this GitHub thread. Visit golang.org/cl/149379.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Sam Whited:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/149379.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Andrew Poydence:

Patch Set 1:

(2 comments)

Patch Set 1:

(3 comments)

API changes generally need a full proposal, and the issue you're fixing was closed so I don't think this will be merged (though you'll have to wait for someone with +2 rights to make the final call on that), but I've included a few comments for future reference. Thanks for contributing!

I will go ahead and file a proposal. I appreciate you taking a look.

Please don’t reply on this GitHub thread. Visit golang.org/cl/149379.
After addressing review feedback, remember to publish your drafts!

@poy
Copy link
Contributor Author

poy commented Nov 13, 2018

This changes the API of T and B. I have opened a proposal #28778

@poy poy closed this Nov 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

proposal: testing: add log.Logger adapter to testing.T
3 participants
@poy @gopherbot @googlebot