New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
crypto/x509: (*Certificate).Equals panics for nil values #28743
Comments
Thank you for this change request @empijei! I'll kindly page @FiloSottile @rsc |
@empijei would you like to send a CL and a test for this? I could have sent a CL but you've already proposed the fix so please go for it. Thank you. |
Thanks, I will asap, but I'm currently stuck on #30776. Will probably submit a fix for this in the next days. |
Cool, no rush. However, I don't think you need to be blocked by ./all.bash. If your fix just involves the nil comparisons and also has some tests, you can submit that but also you can run the tests just in crypto/x509. |
Change https://golang.org/cl/167118 mentions this issue: |
The current implementation panics on nil certificates, so introduce a nil check and early return true if both are nil, false if only one is. Fixes golang#28743 Change-Id: I71b0dee3e505d3ad562a4470ccc22c3a2579bc52 Reviewed-on: https://go-review.googlesource.com/c/go/+/167118 Run-TryBot: Emmanuel Odeke <emm.odeke@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Emmanuel Odeke <emm.odeke@gmail.com>
The current implementation panics on nil certificates, so introduce a nil check and early return true if both are nil, false if only one is. Fixes golang#28743 Change-Id: I71b0dee3e505d3ad562a4470ccc22c3a2579bc52 Reviewed-on: https://go-review.googlesource.com/c/go/+/167118 Run-TryBot: Emmanuel Odeke <emm.odeke@gmail.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Emmanuel Odeke <emm.odeke@gmail.com>
Most methods in Go do not work on
nil
values, and that is perfectly fine, but I feel like(*T).Equal(*T)
should behave more or less like the==
operator.I'm proposing a change that looks like this:
This is analogous to how the regex package does it:
The text was updated successfully, but these errors were encountered: