cmd/vendor/golang.org/x/sys/unix: chase FreeBSD header rename #28742
Conversation
When Capsicum (FreeBSD's capability-based sandboxing framework) was first developed it used sys/capability.h as its header, but that conflicted with the draft POSIX.1e capability header used on other systems (Linux). As a result FreeBSD's header was renamed to sys/capsicum.h, with capability.h remaining as a backwards-compatibility shim. Today all supported (and most unsupported) versions of FreeBSD now have sys/capsicum.h so unconditionally switch to using the updated header.
googlebot
added
the
cla: yes
|
This PR (HEAD: 06cc0b5) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/148836 to see it. Tip: You can toggle comments from me using the |
|
Message from Gobot Gobot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/148836. |
|
Message from Brad Fitzpatrick: Patch Set 1: Code-Review-2 We don't modify things in vendor/* directories manually. You have to fix it upstream first, and then we'll update the copy here later. Please don’t reply on this GitHub thread. Visit golang.org/cl/148836. |
|
Message from Ed Maste: Patch Set 1:
Would you kindly let me know how to find the upstream for this? Please don’t reply on this GitHub thread. Visit golang.org/cl/148836. |
|
Message from Ian Lance Taylor: Patch Set 1:
It's the package golang.org/x/sys/unix. I think this problem is already fixed upstream, actually. If so we just need to vendor in a new version. Please don’t reply on this GitHub thread. Visit golang.org/cl/148836. |
|
Message from Ed Maste: Patch Set 1:
Indeed, it was fixed in 3a27cdc. Please don’t reply on this GitHub thread. Visit golang.org/cl/148836. |
|
This PR is being closed because golang.org/cl/148836 has been abandoned. |
When Capsicum (FreeBSD's capability-based sandboxing framework) was
first developed it used sys/capability.h as its header, but that
conflicted with the draft POSIX.1e capability header used on other
systems (Linux). As a result FreeBSD's header was renamed to
sys/capsicum.h, with capability.h remaining as a backwards-compatibility
shim.
Today all supported (and most unsupported) versions of FreeBSD have
sys/capsicum.h so unconditionally switch to using the updated header.