Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build/cmd/coordinator: some CLs exp subrepo left strange active trybots running #28714

Closed
dmitshur opened this issue Nov 10, 2018 · 4 comments
Closed

x/build/cmd/coordinator: some CLs exp subrepo left strange active trybots running #28714

dmitshur opened this issue Nov 10, 2018 · 4 comments
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unreleased

Comments

@dmitshur
Copy link
Contributor

A few CLs (147877, 147797, 146197) in the exp subrepo started trybots.

They each ended with a trybot run that started, but never finished. E.g.:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=0d16b4a3

image

As a result, farmer shows 3 active trybot runs now, with -2 remaining builds each:

image

/cc @bradfitz

Reporting this for our reference, since I'm about to redeploy coordinator and we might lose this information.
@dmitshur dmitshur added Builders x/build issues (builders, bots, dashboards) NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Nov 10, 2018
@gopherbot gopherbot added this to the Unreleased milestone Nov 10, 2018
@dmitshur
Copy link
Contributor Author

The "Builds Remaining" number calculation is clearly wrong. I've noticed it's sometimes wrong even elsewhere, for trybots that succeed properly. E.g., from this trybot run:

@bradfitz
Copy link
Contributor

Fallout from #17626. Specifically from https://go-review.googlesource.com/c/build/+/143538/ ... before that CL the number of builders in a tryset was always equal to the number of try builders. Apparently I missed that we had made that assumption.

Easy enough fix.

@bradfitz bradfitz self-assigned this Nov 11, 2018
@dmitshur dmitshur added NeedsFix The path to resolution is known, but the work has not been done. and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Nov 11, 2018
@dmitshur
Copy link
Contributor Author

Thanks for diagnosing the issue.

@gopherbot
Copy link

Change https://golang.org/cl/149437 mentions this issue: cmd/coordinator: fix trybot remaining builds count for subrepos

@golang golang locked and limited conversation to collaborators Nov 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@bradfitz @dmitshur @gopherbot