Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/trace: TestAnalyzeAnnotations failing for some users #28702

Closed
jerrinsg opened this issue Nov 9, 2018 · 6 comments
Closed

cmd/trace: TestAnalyzeAnnotations failing for some users #28702

jerrinsg opened this issue Nov 9, 2018 · 6 comments
Labels
FrozenDueToAge help wanted NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Go1.12

Comments

@jerrinsg
Copy link
Contributor

jerrinsg commented Nov 9, 2018

What version of Go are you using (go version)?

$ go version
go version devel +e496e612b7 Fri Nov 9 21:47:48 2018 +0000 linux/amd64

Does this issue reproduce with the latest release?

I am seeing this issue on the master branch

What operating system and processor architecture are you using (go env)?

go env Output
$ go env
$ ./../bin/go env                                                                                                                                                                                         ‹system›
GOARCH="amd64"
GOBIN=""
GOCACHE="~/.cache/go-build"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/home/jerrin/gocode"
GOPROXY=""
GORACE=""
GOROOT="/work/temp/go"
GOTMPDIR=""
GOTOOLDIR="/work/temp/go/pkg/tool/linux_amd64"
GCCGO="gccgo"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build564641832=/tmp/go-build -gno-record-gcc-switches"

What did you do?

Ran all.bash test suite

What did you expect to see?

All tests passing

What did you see instead?

--- FAIL: TestAnalyzeAnnotations (0.01s)
    annotations_test.go:101: failed to trace the program: 16: running before start [g:0 p:1 ProcStart/5 [3 0 0] [] 2445 ->0]
--- FAIL: TestAnalyzeAnnotationGC (0.01s)
    annotations_test.go:271: failed to trace the program: unexpected 18:[g:0 p:0 ProcStop/6 [0 0 0] [] 2c23 ->0] [true 23 <nil> <nil>]
FAIL
FAIL	cmd/trace	0.066s

Full set of logs - test.log
@bradfitz bradfitz changed the title all.bash failing on master cmd/trace: TestAnalyzeAnnotations failing for some users Nov 9, 2018
@bradfitz bradfitz added Testing An issue that has been verified to require only test changes, not just a test failure. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker help wanted labels Nov 9, 2018
@bradfitz bradfitz added this to the Go1.12 milestone Nov 9, 2018
@bradfitz
Copy link
Contributor

bradfitz commented Nov 9, 2018

What version of Linux? You running on bare metal, in a VM on your desktop, on a cloud provider?

@bradfitz
Copy link
Contributor

bradfitz commented Nov 9, 2018

/cc @aclements

@jerrinsg
Copy link
Contributor Author

jerrinsg commented Nov 9, 2018

I ran this on a bare metal Ubuntu 18.04.1 LTS (desktop version)

$ uname -a
Linux Precision-T3610 4.15.0-38-generic #41-Ubuntu SMP Wed Oct 10 10:59:38 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

I can reliably reproduce the issue on this machine.

But the tests run without any issue on another Ubuntu VM running Ubuntu 18.04.1 LTS (GNU/Linux 4.15.0-38-generic x86_64) (server version) ...

@hyangah
Copy link
Contributor

hyangah commented Nov 29, 2018

@jerrinsg We recently reverted some of the recent changes in trace parser. Do you still observe the test failures with tip?

@jerrinsg
Copy link
Contributor Author

jerrinsg commented Nov 29, 2018 •
edited

I don't see the test failures after pulling in the latest changes (at 2140975 cmd/compile: eliminate write barriers when writing non-heap ptrs).

I do see the failures when I go back to commit e496e61 runtime: never call into race detector with retaken P

@hyangah
Copy link
Contributor

hyangah commented Dec 5, 2018

I guess golang.org/cl/150517 that reverted the trace parser change fixed this issue. ( 6d5caf3)

@hyangah hyangah closed this as completed Dec 5, 2018
@jerrinsg jerrinsg mentioned this issue Aug 19, 2019
Closed
@golang golang locked and limited conversation to collaborators Aug 18, 2020
@rsc rsc unassigned hyangah Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge help wanted NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. release-blocker Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Go1.12
Development

No branches or pull requests
4 participants
@bradfitz @jerrinsg @hyangah @gopherbot