Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/compile: refine calcHasCall's handling of ODIV and OMOD #28698

Open
josharian opened this issue Nov 9, 2018 · 2 comments
Open

cmd/compile: refine calcHasCall's handling of ODIV and OMOD #28698

josharian opened this issue Nov 9, 2018 · 2 comments
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. NeedsFix The path to resolution is known, but the work has not been done. Suggested Issues that may be good for new contributors looking for work to do.
Milestone
Backlog

Comments

@josharian
Copy link
Contributor

@cherrymui noted in the review of CL 148837 that on non-soft-float platforms, when working with floats, ODIV and OMOD won't panic. We should handle them a bit more precisely in calcHasCall.
@josharian josharian added Suggested Issues that may be good for new contributors looking for work to do. NeedsFix The path to resolution is known, but the work has not been done. labels Nov 9, 2018
@josharian josharian added this to the Go1.13 milestone Nov 9, 2018
@gopherbot
Copy link

Change https://golang.org/cl/166937 mentions this issue: cmd: handle floats for ODIV better

@andybons andybons modified the milestones: Go1.13, Go1.14 Jul 8, 2019
@aenkya
Copy link

aenkya commented Oct 4, 2019

I'd like to take a go at this 👋 🙂

@rsc rsc modified the milestones: Go1.14, Backlog Oct 9, 2019
@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. NeedsFix The path to resolution is known, but the work has not been done. Suggested Issues that may be good for new contributors looking for work to do.
Projects
Go Compiler / Runtime
Status: Triage Backlog
Milestone
Backlog
Development

No branches or pull requests
5 participants
@josharian @rsc @andybons @aenkya @gopherbot