Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bufio: fix indexes in TestWriter #28693

Closed
wants to merge 1 commit into from
Closed

bufio: fix indexes in TestWriter #28693

wants to merge 1 commit into from

Conversation

ry
Copy link
Contributor

@ry ry commented Nov 9, 2018

No description provided.

@googlebot googlebot added the cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. label Nov 9, 2018
@gopherbot
Copy link

This PR (HEAD: f3d59fe) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/148818 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link

Message from Gobot Gobot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
Within the next week or so, a maintainer will review your change and provide
feedback. See https://golang.org/doc/contribute.html#review for more info and
tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11, it means that this CL will be reviewed as part of the next development
cycle. See https://golang.org/s/release for more details.


Please don’t reply on this GitHub thread. Visit golang.org/cl/148818.
After addressing review feedback, remember to publish your drafts!

@bradfitz bradfitz changed the title bufio: fixes indicies in TestWriter bufio: fix indicies in TestWriter Nov 9, 2018
@gopherbot
Copy link

Message from Brad Fitzpatrick:

Patch Set 1: Run-TryBot+1 Code-Review+2


Please don’t reply on this GitHub thread. Visit golang.org/cl/148818.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Gobot Gobot:

Patch Set 1:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=b29af233


Please don’t reply on this GitHub thread. Visit golang.org/cl/148818.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Ian Lance Taylor:

Patch Set 2: Run-TryBot+1

(1 comment)

Thanks for spotting this.


Please don’t reply on this GitHub thread. Visit golang.org/cl/148818.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Gobot Gobot:

Patch Set 2:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=df151c0b


Please don’t reply on this GitHub thread. Visit golang.org/cl/148818.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

This PR (HEAD: 5d53406) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/148818 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link

Message from Brad Fitzpatrick:

Patch Set 3:

Ryan, the bot that maps 1+ GitHub PR commits to exactly 1 Gerrit commit doesn't use the original commit(s) text. It uses the PR title + body instead.

See https://github.com/golang/go/wiki/CommitMessage#github-pull-requests


Please don’t reply on this GitHub thread. Visit golang.org/cl/148818.
After addressing review feedback, remember to publish your drafts!

@ry ry changed the title bufio: fix indicies in TestWriter bufio: fix indexes in TestWriter Nov 9, 2018
@gopherbot
Copy link

Message from Ian Lance Taylor:

Patch Set 4: Run-TryBot+1


Please don’t reply on this GitHub thread. Visit golang.org/cl/148818.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Gobot Gobot:

Patch Set 4:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=19369a2d


Please don’t reply on this GitHub thread. Visit golang.org/cl/148818.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Gobot Gobot:

Patch Set 4: TryBot-Result-1

1 of 19 TryBots failed:
Failed on freebsd-amd64-12_0: https://storage.googleapis.com/go-build-log/19369a2d/freebsd-amd64-12_0_1e8d3af6.log

Consult https://build.golang.org/ to see whether they are new failures.


Please don’t reply on this GitHub thread. Visit golang.org/cl/148818.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

This PR is being closed because golang.org/cl/148818 has been merged.

@gopherbot gopherbot closed this Nov 9, 2018
gopherbot pushed a commit that referenced this pull request Nov 9, 2018
Change-Id: I393c53d6f7b526d156226502544725a4cb9fb118
GitHub-Last-Rev: 5d53406
GitHub-Pull-Request: #28693
Reviewed-on: https://go-review.googlesource.com/c/148818
Run-TryBot: Ian Lance Taylor <iant@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants