New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bufio: fix indexes in TestWriter #28693
Conversation
This PR (HEAD: f3d59fe) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/148818 to see it. Tip: You can toggle comments from me using the |
Message from Gobot Gobot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/148818. |
Message from Brad Fitzpatrick: Patch Set 1: Run-TryBot+1 Code-Review+2 Please don’t reply on this GitHub thread. Visit golang.org/cl/148818. |
Message from Gobot Gobot: Patch Set 1: TryBots beginning. Status page: https://farmer.golang.org/try?commit=b29af233 Please don’t reply on this GitHub thread. Visit golang.org/cl/148818. |
Message from Ian Lance Taylor: Patch Set 2: Run-TryBot+1 (1 comment) Thanks for spotting this. Please don’t reply on this GitHub thread. Visit golang.org/cl/148818. |
Message from Gobot Gobot: Patch Set 2: TryBots beginning. Status page: https://farmer.golang.org/try?commit=df151c0b Please don’t reply on this GitHub thread. Visit golang.org/cl/148818. |
This PR (HEAD: 5d53406) has been imported to Gerrit for code review. Please visit https://go-review.googlesource.com/c/go/+/148818 to see it. Tip: You can toggle comments from me using the |
Message from Brad Fitzpatrick: Patch Set 3: Ryan, the bot that maps 1+ GitHub PR commits to exactly 1 Gerrit commit doesn't use the original commit(s) text. It uses the PR title + body instead. See https://github.com/golang/go/wiki/CommitMessage#github-pull-requests Please don’t reply on this GitHub thread. Visit golang.org/cl/148818. |
Message from Ian Lance Taylor: Patch Set 4: Run-TryBot+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/148818. |
Message from Gobot Gobot: Patch Set 4: TryBots beginning. Status page: https://farmer.golang.org/try?commit=19369a2d Please don’t reply on this GitHub thread. Visit golang.org/cl/148818. |
Message from Gobot Gobot: Patch Set 4: TryBot-Result-1 1 of 19 TryBots failed: Consult https://build.golang.org/ to see whether they are new failures. Please don’t reply on this GitHub thread. Visit golang.org/cl/148818. |
This PR is being closed because golang.org/cl/148818 has been merged. |
Change-Id: I393c53d6f7b526d156226502544725a4cb9fb118 GitHub-Last-Rev: 5d53406 GitHub-Pull-Request: #28693 Reviewed-on: https://go-review.googlesource.com/c/148818 Run-TryBot: Ian Lance Taylor <iant@golang.org> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
No description provided.