Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build/cmd/pubsubhelper: use cloud pubsub for Gerrit instead of email #28675

Open
bradfitz opened this issue Nov 8, 2018 · 5 comments
Open

x/build/cmd/pubsubhelper: use cloud pubsub for Gerrit instead of email #28675

bradfitz opened this issue Nov 8, 2018 · 5 comments
Labels
Builders x/build issues (builders, bots, dashboards)
Projects
Go Release Team
Milestone
Unreleased

Comments

@bradfitz
Copy link
Contributor

bradfitz commented Nov 8, 2018 •
edited

When I wrote pubsubhelper, Gerrit didn't support Cloud Pub Sub, so we had to parse emails to get live notifications out of Gerrit.

But @andybons pointed out that now it does, so we should move to it.

Low priority, but would be a nice cleanup.
@gopherbot gopherbot added this to the Unreleased milestone Nov 8, 2018
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Nov 8, 2018
@bradfitz
Copy link
Contributor Author

bradfitz commented Nov 8, 2018

For Google internal docs on how to set it up for our Gerrit instead, see http://go/golang-issue-28675-docs

@andybons
Copy link
Member

andybons commented Nov 9, 2018

Public docs: https://cloud.google.com/source-repositories/docs/quickstart-adding-pubsub-notifications

@bradfitz
Copy link
Contributor Author

@andybons, IIRC, you said their pubsub topic today is still insufficient? It does't include all the NoteDB changes or something?

@bradfitz
Copy link
Contributor Author

(For background for others, we currently run https://pubsubhelper.golang.org/ which is a fake email server that listens to Gerrit emails to know when things happen on Gerrit.)

@dmitshur
Copy link
Contributor

CC @heschi.

@heschi heschi self-assigned this Jul 26, 2022
@dmitshur dmitshur added this to Planned in Go Release Team Aug 2, 2022
@heschi heschi removed their assignment Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards)
Projects
Go Release
Status: Planned
Go Release Team
Planned
Milestone
Unreleased
Development

No branches or pull requests
5 participants
@bradfitz @andybons @dmitshur @gopherbot @heschi