New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gccgo: hugo tests fail with gccgo, works fine with gc #28669
Comments
Fragile test making too many assumptions, or something gccgo should strive to match, even if not required? |
Thanks for reporting this. This is a problem with the test, not with gccgo. Sent gohugoio/hugo#5423 to fix it. |
When run under gccgo, the test looks for the name that gccgo gives to a thunk method. This name is not normally visible, but can be seen when using reflect.FuncForPC as this code does. That name changed in https://golang.org/cl/89555. Change the test to work with both the old name "$thunk0" and the new name "thunk0". Fixes golang/go#28669
This test was originally adjusted to make the Debian build happy, so I guess this is full circle. The test in question is kind of superfluous, as lots of other tests would break if this name mapping construct was broken. But it should go green for Debian now. |
@bep Thanks. |
Trying to build
hugo
with gccgo fails because the testsuite fails with:Full log available at: https://people.debian.org/~glaubitz/gccgo-logs/hugo_0.47.1-2_amd64.build
The text was updated successfully, but these errors were encountered: