Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gccgo: snapd doesn't compile with gccgo, builds fine with gc #28664

Closed
glaubitz opened this issue Nov 8, 2018 · 2 comments
Closed

gccgo: snapd doesn't compile with gccgo, builds fine with gc #28664

glaubitz opened this issue Nov 8, 2018 · 2 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided.
Milestone
Gccgo

Comments

@glaubitz
Copy link

glaubitz commented Nov 8, 2018

Trying to build snapd with gccgo fails with:

...
github.com/snapcore/snapd/overlord
github.com/snapcore/snapd/overlord/servicestate
github.com/snapcore/snapd/overlord/hookstate/ctlcmd
github.com/snapcore/snapd/polkit
github.com/snapcore/snapd/daemon
# github.com/snapcore/snapd/daemon
src/github.com/snapcore/snapd/daemon/daemon.go:276:40: too many arguments in call to activation.Listeners
        have (bool)
        want ()
go/parser
github.com/snapcore/snapd/i18n/xgettext-go
flag
go/printer
runtime/debug
runtime/trace
testing
gopkg.in/check.v1
github.com/snapcore/snapd/snap/snaptest
github.com/snapcore/snapd/interfaces/ifacetest
github.com/snapcore/snapd/overlord/hookstate/hooktest
github.com/snapcore/snapd/progress/progresstest
github.com/snapcore/snapd/store/storetest
github.com/snapcore/snapd/testutil
...

Full log available at: https://people.debian.org/~glaubitz/gccgo-logs/snapd_2.30-5_amd64.build
@gopherbot gopherbot added this to the Gccgo milestone Nov 8, 2018
@ianlancetaylor
Copy link
Contributor

I'm not sure what is going on here. That error message could not come from gccgo. That is an error message generated by the gc compiler, not the gccgo compiler. For this kind of case the gccgo compiler would emit an error like

src/github.com/snapcore/snapd/daemon/daemon.go:276:40: error: too many arguments

followed by a display of the line with a caret pointing to that position. It would not display the "have" and "want" lines shown above.

For me, that package builds with both gc and gccgo with no trouble, both on tip and on the 2.30 tar in the repo.

Can you double check that this really using gccgo? Can you give me a recipe that I can use to recreate the problem? Thanks.

@ianlancetaylor ianlancetaylor added WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Nov 9, 2018
@gopherbot
Copy link

Timed out in state WaitingForInfo. Closing.

(I am just a bot, though. Please speak up if this is a mistake or you have the requested information.)

@golang golang locked and limited conversation to collaborators Dec 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided.
Projects
None yet
Milestone
Gccgo
Development

No branches or pull requests
3 participants
@glaubitz @ianlancetaylor @gopherbot