Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build/cmd/gerritbot: github PR bot does not say who wrote CL #28662

Closed
rsc opened this issue Nov 8, 2018 · 3 comments
Closed

x/build/cmd/gerritbot: github PR bot does not say who wrote CL #28662

rsc opened this issue Nov 8, 2018 · 3 comments
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unreleased

Comments

@rsc
Copy link
Contributor

rsc commented Nov 8, 2018

I can't see who wrote https://go-review.googlesource.com/c/go/+/148477
unless I open the "Commit message" file entry.

Can we please get that fixed?

The best option would be to have Gerrit show the author and
commit lines in the commit message shown on the front page
but since we probably can't make that happen soon,
let's at least make the bot post in its first message
some minimal explanatory text like

This Gerrit CL corresponds to GitHub PR golang/go#00000.

Author: Jane Gopher <jane@goph.er>

Thanks.
@rsc rsc added this to the Unreleased milestone Nov 8, 2018
@gopherbot gopherbot mentioned this issue Nov 8, 2018
Closed
@rsc rsc mentioned this issue Nov 8, 2018
Closed
@bradfitz bradfitz changed the title github PR bot does not say who wrote CL x/build/gerritbot: github PR bot does not say who wrote CL Nov 8, 2018
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Nov 8, 2018
@bradfitz
Copy link
Contributor

bradfitz commented Nov 8, 2018

This is almost a dup of #24837, but this bug has good workarounds in the meantime, as #24837 is a bit idealistic and largely out of our hands.

/cc @andybons @dmitshur @FiloSottile @katiehockman

@bradfitz bradfitz added the NeedsFix The path to resolution is known, but the work has not been done. label Nov 8, 2018
@andybons andybons changed the title x/build/gerritbot: github PR bot does not say who wrote CL x/build/cmd/gerritbot: github PR bot does not say who wrote CL Nov 8, 2018
@andybons
Copy link
Member

andybons commented Nov 8, 2018

We can use https://gerrit-review.googlesource.com/Documentation/user-upload.html#message to add a message upon upload.

@gopherbot
Copy link

Change https://golang.org/cl/148564 mentions this issue: cmd/gerritbot: add informational message upon initial upload of CL

@golang golang locked and limited conversation to collaborators Nov 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
4 participants
@bradfitz @rsc @andybons @gopherbot