Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

strings: remove empty line #28659

Closed
wants to merge 1 commit into from
Closed

Conversation

smileusd
Copy link
Contributor

@smileusd smileusd commented Nov 8, 2018

No description provided.

@googlebot googlebot added the cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change. label Nov 8, 2018
@gopherbot
Copy link

This PR (HEAD: eb8f800) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/go/+/148477 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link

Message from Gerrit User 5976:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps:
Within the next week or so, a maintainer will review your change and provide
feedback. See https://golang.org/doc/contribute.html#review for more info and
tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be
surprising to people new to the project. The careful, iterative review process
is our way of helping mentor contributors and ensuring that their contributions
have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which
little code gets reviewed or merged. If a reviewer responds with a comment like
R=go1.11, it means that this CL will be reviewed as part of the next development
cycle. See https://golang.org/s/release for more details.


Please don’t reply on this GitHub thread. Visit golang.org/cl/148477.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Gerrit User 5056:

Patch Set 1:

I don't understand what's going on here. Who is "Gerrit Bot"?


Please don’t reply on this GitHub thread. Visit golang.org/cl/148477.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Gerrit User 5056:

Patch Set 1:

Oh, I see, this is one of the Github PR conversions.
This should be made MUCH clearer in the first message that "Gerrit Bot" sends.
I shouldn't have to open the "Commit message" file diff to find out
who has sent the PR.


Please don’t reply on this GitHub thread. Visit golang.org/cl/148477.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Gerrit User 5056:

Patch Set 1: Code-Review+2

CL looks fine, thanks.

Filed #28662 for my confusion here.


Please don’t reply on this GitHub thread. Visit golang.org/cl/148477.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Gerrit User 5065:

Patch Set 1:

Submitting, but let's limit cleanups during the freeze.


Please don’t reply on this GitHub thread. Visit golang.org/cl/148477.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request Nov 8, 2018
Change-Id: Ibdca4f7002585b00d7f69d710285a8e0f69c598a
GitHub-Last-Rev: eb8f800
GitHub-Pull-Request: #28659
Reviewed-on: https://go-review.googlesource.com/c/148477
Reviewed-by: Russ Cox <rsc@golang.org>
@gopherbot
Copy link

This PR is being closed because golang.org/cl/148477 has been merged.

@gopherbot gopherbot closed this Nov 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Used by googlebot to label PRs as having a valid CLA. The text of this label should not change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants