x/build/cmd/coordinator: build dashboard for subrepos is confusing #28643
Comments
|
Which page are you talking about? This one? https://build.golang.org/?repo=golang.org%2fx%2ftools |
|
@bradfitz Yes, that's the page Michael was referring to. |
|
Yeah that's the page.
…On Thu, Nov 8, 2018 at 2:32 PM Dmitri Shuralyov ***@***.***> wrote:
@bradfitz <https://github.com/bradfitz> Yes, that's the page Michael was
referring to.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#28643 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/APtQJXQmqZbG2EjWLlaTs73DffRimOvLks5utIa4gaJpZM4YTIbr>
.
|
|
Change https://golang.org/cl/244137 mentions this issue: |
The build dashboard can be used to view builds for the main Go repo and other golang.org/x repos. The isUntested invocation was invalid for repos other than the main one, which was causing results for some tested configurations to become hidden (incorrectly replaced by '•'). Larger changes are needed before there's sufficient data to compute the GoBranch value for all repos reliably, so for now, just update the isUntested invocation to apply only for the main repo. This prioritizes the ability to view test results over the ability to see that some builds are intentionally missing because they are configured not to run. Doing both is a part of future work. For golang/go#40290. For golang/go#34744. For golang/go#28643. Change-Id: Id43cb47abacb1036f578efbb8232ae17ad40eca9 Reviewed-on: https://go-review.googlesource.com/c/build/+/244137 Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Alexander Rakoczy <alex@golang.org> Reviewed-by: Carlos Amedee <carlos@golang.org>
|
Change https://golang.org/cl/245277 mentions this issue: |
dmitshur
added
the
NeedsInvestigation
dmitshur
changed the title
|
Our migration to LUCI should make a meaningful improvement for golang.org/x repo result views. Using a recent issue #67439 as an example, where CL 546676 introduced a net/http behavior change that broke a test in x/build and CL 586315 fixed it, this can be cleanly deduced from LUCI's "by Go commit" views:
(For comparison, the old view shows this as this, with interleaving "ok" rows that are actually results from different release branches.) I don't anticipate we'll be doing more feature work on this in the coordinator codebase, so closing this. |
|
Change https://go.dev/cl/644156 mentions this issue: |
The build.golang.org dashboard gained support to display build results from LUCI, in addition to legacy builder results (go.dev/issue/65913), but only for the default top-level view. When visiting more detailed pages, like page 2 of commits for the main Go repo, or detailed views for golang.org/x repos, no LUCI build results are shown, which can be confusing. So, when displaying LUCI results (i.e., the 'legacyonly' query parameter isn't used to hide them), change links to detailed views on the top-level view to point to the LUCI UI where results can in fact be viewed. For golang/go#28643. For golang/go#65913. For golang/go#70314. Change-Id: I3ebfba5bc6d0cd2e37d8e5fc1386843c6e298ce7 Reviewed-on: https://go-review.googlesource.com/c/build/+/644156 Reviewed-by: Michael Knyszek <mknyszek@google.com> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
cc @dmitshur
The build dashboard for subrepos is a bit hard to read. The the go distribution that's tested against is given as a commit hash, which is sometimes useful but most of the time I care about which version of Go is tested against especially since multiple versions of Go appear in the dashboard.
It's a little hard to tell which version of Go is tested against which version of the subrepo. It might be helpful to combine the rows for a given version of the subrepo.
The text was updated successfully, but these errors were encountered: