-
Notifications
You must be signed in to change notification settings - Fork 17.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/tools/internal/lsp: TestDiagnostics/GOPATH is failing on Go 1.10 #28581
Labels
Milestone
Comments
It looks like this started to happen after CL 145697. I can reproduce locally:
/cc @stamblerre |
Sorry for the delay on fixing it--we were trying to decide the best approach for testing different versions of Go. Should be fixed by https://go-review.googlesource.com/c/tools/+/147439. |
No worries, thanks for taking care of it! Now that #17626 is resolved, trybots should help catch this in advance next time. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
On Go 1.10:
The test is passing on Go 1.11 and tip.
Source: https://build.golang.org/?repo=golang.org%2fx%2ftools
/cc @heschik @ianthehat
The text was updated successfully, but these errors were encountered: