Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/vendor/golang.org/x/arch/arm/arm64asm: TestObjdumpARM64TestDecode{GNU,Go}Syntaxdata FAIL #28578

Closed
cznic opened this issue Nov 3, 2018 · 4 comments
Closed

cmd/vendor/golang.org/x/arch/arm/arm64asm: TestObjdumpARM64TestDecode{GNU,Go}Syntaxdata FAIL #28578

cznic opened this issue Nov 3, 2018 · 4 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided.
Milestone
Go1.12

Comments

@cznic
Copy link
Contributor

cznic commented Nov 3, 2018

What version of Go are you using (go version)?

go version go1.11.2 linux/amd64

Does this issue reproduce with the latest release?

Yes.

What operating system and processor architecture are you using (go env)?

GOARCH="amd64"
GOBIN=""
GOCACHE="/home/jnml/.cache/go-build"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/home/jnml"
GOPROXY=""
GORACE=""
GOROOT="/home/jnml/go"
GOTMPDIR=""
GOTOOLDIR="/home/jnml/go/pkg/tool/linux_amd64"
GCCGO="gccgo"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build573162995=/tmp/go-build -gno-record-gcc-switches"

What did you do?

==== jnml@4670:~/go/src> git status 
HEAD detached at go1.11.2
nothing to commit, working tree clean
==== jnml@4670:~/go/src> git --no-pager log -1
commit e8a95aeb75536496432bcace1fb2bbfa449bf0fa (HEAD, tag: go1.11.2, origin/release-branch.go1.11)
Author: Andrew Bonventre <andybons@golang.org>
Date:   Fri Nov 2 15:56:16 2018 -0400

    [release-branch.go1.11] go1.11.2
    
    Change-Id: Idd3527ba8f2329876cbca646aacd97739b9828f7
    Reviewed-on: https://go-review.googlesource.com/c/147217
    Run-TryBot: Andrew Bonventre <andybons@golang.org>
    TryBot-Result: Gobot Gobot <gobot@golang.org>
    Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
==== jnml@4670:~/go/src> ./all.bash

What did you expect to see?

New Go release built and tests pass.

What did you see instead?

==== jnml@4670:~/go/src> ./all.bash 
Building Go cmd/dist using /home/jnml/go1.4.
Building Go toolchain1 using /home/jnml/go1.4.
Building Go bootstrap cmd/go (go_bootstrap) using Go toolchain1.
Building Go toolchain2 using go_bootstrap and Go toolchain1.
Building Go toolchain3 using go_bootstrap and Go toolchain2.
Building packages and commands for linux/amd64.

##### Testing packages.
ok  	archive/tar	0.025s
ok  	archive/zip	1.278s
ok  	bufio	0.071s
ok  	bytes	0.127s
ok  	compress/bzip2	0.098s
ok  	compress/flate	0.673s
ok  	compress/gzip	0.035s
ok  	compress/lzw	0.007s
ok  	compress/zlib	0.017s
ok  	container/heap	0.006s
ok  	container/list	0.001s
ok  	container/ring	0.011s
ok  	context	1.000s
ok  	crypto	0.002s
ok  	crypto/aes	0.022s
ok  	crypto/cipher	0.048s
ok  	crypto/des	0.008s
ok  	crypto/dsa	0.030s
ok  	crypto/ecdsa	0.092s
ok  	crypto/elliptic	0.526s
ok  	crypto/hmac	0.001s
ok  	crypto/internal/subtle	0.002s
ok  	crypto/md5	0.002s
ok  	crypto/rand	0.032s
ok  	crypto/rc4	0.050s
ok  	crypto/rsa	0.056s
ok  	crypto/sha1	0.014s
ok  	crypto/sha256	0.009s
ok  	crypto/sha512	0.008s
ok  	crypto/subtle	0.006s
ok  	crypto/tls	0.529s
ok  	crypto/x509	0.724s
ok  	database/sql	0.556s
ok  	database/sql/driver	0.001s
ok  	debug/dwarf	0.009s
ok  	debug/elf	0.011s
ok  	debug/gosym	0.209s
ok  	debug/macho	0.003s
ok  	debug/pe	0.009s
ok  	debug/plan9obj	0.021s
ok  	encoding/ascii85	0.010s
ok  	encoding/asn1	0.013s
ok  	encoding/base32	0.008s
ok  	encoding/base64	0.019s
ok  	encoding/binary	0.002s
ok  	encoding/csv	0.033s
ok  	encoding/gob	0.025s
ok  	encoding/hex	0.002s
ok  	encoding/json	0.263s
ok  	encoding/pem	0.008s
ok  	encoding/xml	0.027s
ok  	errors	0.001s
ok  	expvar	0.016s
ok  	flag	0.008s
ok  	fmt	0.068s
ok  	go/ast	0.005s
ok  	go/build	0.106s
ok  	go/constant	0.003s
ok  	go/doc	0.027s
ok  	go/format	0.007s
ok  	go/importer	0.063s
ok  	go/internal/gccgoimporter	0.047s
ok  	go/internal/gcimporter	0.313s
ok  	go/internal/srcimporter	0.660s
ok  	go/parser	0.020s
ok  	go/printer	0.256s
ok  	go/scanner	0.018s
ok  	go/token	0.012s
ok  	go/types	0.569s
ok  	hash	0.014s
ok  	hash/adler32	0.009s
ok  	hash/crc32	0.004s
ok  	hash/crc64	0.012s
ok  	hash/fnv	0.009s
ok  	html	0.012s
ok  	html/template	0.025s
ok  	image	0.072s
ok  	image/color	0.037s
ok  	image/draw	0.030s
ok  	image/gif	0.328s
ok  	image/jpeg	0.133s
ok  	image/png	0.038s
ok  	index/suffixarray	0.028s
ok  	internal/cpu	0.002s
ok  	internal/poll	0.024s
ok  	internal/singleflight	0.022s
ok  	internal/trace	0.957s
ok  	io	0.049s
ok  	io/ioutil	0.002s
ok  	log	0.006s
ok  	log/syslog	1.215s
ok  	math	0.002s
ok  	math/big	1.602s
ok  	math/bits	0.002s
ok  	math/cmplx	0.001s
ok  	math/rand	0.221s
ok  	mime	0.009s
ok  	mime/multipart	0.315s
ok  	mime/quotedprintable	0.100s
ok  	net	1.822s
ok  	net/http	3.258s
ok  	net/http/cgi	0.558s
ok  	net/http/cookiejar	0.068s
ok  	net/http/fcgi	0.019s
ok  	net/http/httptest	0.009s
ok  	net/http/httptrace	0.002s
ok  	net/http/httputil	0.020s
ok  	net/http/internal	0.002s
ok  	net/http/pprof	2.012s
ok  	net/internal/socktest	0.003s
ok  	net/mail	0.010s
ok  	net/rpc	0.017s
ok  	net/rpc/jsonrpc	0.003s
ok  	net/smtp	0.007s
ok  	net/textproto	0.010s
ok  	net/url	0.006s
ok  	os	0.812s
ok  	os/exec	0.488s
ok  	os/signal	4.783s
ok  	os/user	0.002s
ok  	path	0.001s
ok  	path/filepath	0.007s
ok  	reflect	0.128s
ok  	regexp	0.160s
ok  	regexp/syntax	0.259s
ok  	runtime	26.807s
ok  	runtime/debug	0.015s
ok  	runtime/internal/atomic	0.103s
ok  	runtime/internal/sys	0.015s
ok  	runtime/pprof	6.540s
ok  	runtime/pprof/internal/profile	0.050s
ok  	runtime/trace	2.781s
ok  	sort	0.045s
ok  	strconv	0.341s
ok  	strings	0.149s
ok  	sync	0.434s
ok  	sync/atomic	0.084s
ok  	syscall	0.185s
ok  	testing	1.279s
ok  	testing/quick	0.205s
ok  	text/scanner	0.043s
ok  	text/tabwriter	0.073s
ok  	text/template	0.246s
ok  	text/template/parse	0.027s
ok  	time	2.661s
ok  	unicode	0.002s
ok  	unicode/utf16	0.006s
ok  	unicode/utf8	0.008s
ok  	vendor/golang_org/x/crypto/chacha20poly1305	0.321s
ok  	vendor/golang_org/x/crypto/cryptobyte	0.010s
ok  	vendor/golang_org/x/crypto/curve25519	0.010s
ok  	vendor/golang_org/x/crypto/internal/chacha20	0.028s
ok  	vendor/golang_org/x/crypto/poly1305	0.007s
ok  	vendor/golang_org/x/net/dns/dnsmessage	0.040s
ok  	vendor/golang_org/x/net/http/httpguts	0.005s
ok  	vendor/golang_org/x/net/http/httpproxy	0.002s
ok  	vendor/golang_org/x/net/http2/hpack	0.012s
ok  	vendor/golang_org/x/net/idna	0.002s
ok  	vendor/golang_org/x/net/nettest	1.032s
ok  	vendor/golang_org/x/text/transform	0.004s
ok  	vendor/golang_org/x/text/unicode/norm	0.001s
ok  	cmd/addr2line	1.311s
ok  	cmd/api	0.021s
ok  	cmd/asm/internal/asm	0.414s
ok  	cmd/asm/internal/lex	0.011s
ok  	cmd/compile	0.044s
ok  	cmd/compile/internal/gc	6.467s
ok  	cmd/compile/internal/ssa	0.267s
ok  	cmd/compile/internal/syntax	0.011s
ok  	cmd/compile/internal/test	0.002s [no tests to run]
ok  	cmd/compile/internal/types	0.001s
ok  	cmd/cover	3.306s
ok  	cmd/doc	0.049s
ok  	cmd/fix	3.422s
ok  	cmd/go	36.779s
ok  	cmd/go/internal/cache	0.184s
ok  	cmd/go/internal/dirhash	0.002s
ok  	cmd/go/internal/generate	0.011s
ok  	cmd/go/internal/get	0.046s
ok  	cmd/go/internal/imports	0.008s
ok  	cmd/go/internal/load	0.008s
ok  	cmd/go/internal/modconv	0.042s
ok  	cmd/go/internal/modfetch	0.006s
ok  	cmd/go/internal/modfetch/codehost	0.014s
ok  	cmd/go/internal/modfile	0.012s
ok  	cmd/go/internal/modload	0.016s
ok  	cmd/go/internal/module	0.015s
ok  	cmd/go/internal/mvs	0.023s
ok  	cmd/go/internal/par	0.014s
ok  	cmd/go/internal/search	0.008s
ok  	cmd/go/internal/semver	0.014s
ok  	cmd/go/internal/txtar	0.003s
ok  	cmd/go/internal/web2	0.003s
ok  	cmd/go/internal/work	0.027s
ok  	cmd/gofmt	0.023s
ok  	cmd/internal/buildid	0.111s
ok  	cmd/internal/dwarf	0.003s
ok  	cmd/internal/edit	0.006s
ok  	cmd/internal/goobj	0.385s
ok  	cmd/internal/obj	0.008s
ok  	cmd/internal/obj/arm64	0.012s
ok  	cmd/internal/obj/x86	0.275s
ok  	cmd/internal/objabi	0.008s
ok  	cmd/internal/src	0.013s
ok  	cmd/internal/test2json	0.068s
ok  	cmd/link	1.339s
ok  	cmd/link/internal/ld	5.679s
ok  	cmd/link/internal/sym	0.001s
ok  	cmd/nm	2.181s
ok  	cmd/objdump	1.351s
ok  	cmd/pack	1.418s
ok  	cmd/trace	0.012s
ok  	cmd/vendor/github.com/google/pprof/internal/binutils	0.037s
ok  	cmd/vendor/github.com/google/pprof/internal/driver	0.391s
ok  	cmd/vendor/github.com/google/pprof/internal/elfexec	0.001s
ok  	cmd/vendor/github.com/google/pprof/internal/graph	0.009s
ok  	cmd/vendor/github.com/google/pprof/internal/measurement	0.018s
ok  	cmd/vendor/github.com/google/pprof/internal/report	0.071s
ok  	cmd/vendor/github.com/google/pprof/internal/symbolizer	0.004s
ok  	cmd/vendor/github.com/google/pprof/internal/symbolz	0.021s
ok  	cmd/vendor/github.com/google/pprof/profile	0.044s
ok  	cmd/vendor/github.com/ianlancetaylor/demangle	0.015s
ok  	cmd/vendor/golang.org/x/arch/arm/armasm	0.021s
--- FAIL: TestObjdumpARM64TestDecodeGNUSyntaxdata (0.15s)
    ext_test.go:197: decode(9f3003d5) = "dsb #0x00", 4, want "ssbb", 4
        
    ext_test.go:197: decode(9f3403d5) = "dsb #0x04", 4, want "pssbb", 4
        
    ext_test.go:203: 4651 test cases, 933 expected mismatches, 2 failures; 70728 cases/second
    ext_test.go:204: decoder coverage: 96.4%;
    ext_test.go:203: 4651 test cases, 0 expected mismatches, 0 failures; 67531 cases/second
    ext_test.go:204: decoder coverage: 96.4%;
--- FAIL: TestObjdumpARM64TestDecodeGoSyntaxdata (0.15s)
    ext_test.go:197: decode(9f3003d5) = "dsb #0x00", 4, want "ssbb", 4
        
    ext_test.go:197: decode(9f3403d5) = "dsb #0x04", 4, want "pssbb", 4
        
    ext_test.go:203: 4564 test cases, 964 expected mismatches, 2 failures; 67933 cases/second
    ext_test.go:204: decoder coverage: 96.4%;
    ext_test.go:203: 4564 test cases, 0 expected mismatches, 0 failures; 62935 cases/second
    ext_test.go:204: decoder coverage: 96.4%;
FAIL
FAIL	cmd/vendor/golang.org/x/arch/arm64/arm64asm	2.793s
ok  	cmd/vendor/golang.org/x/arch/ppc64/ppc64asm	0.017s
ok  	cmd/vendor/golang.org/x/arch/x86/x86asm	0.109s
ok  	cmd/vendor/golang.org/x/crypto/ssh/terminal	0.014s
ok  	cmd/vendor/golang.org/x/sys/unix	0.368s
ok  	cmd/vet	1.887s
ok  	cmd/vet/internal/cfg	0.009s
2018/11/03 15:42:12 Failed: exit status 1
==== jnml@4670:~/go/src>
@cznic cznic changed the title cmd/vendor/golang.org/x/arch/arm/armasm: TestObjdumpARM64TestDecode{GNU,Go}Syntaxdata FAIL cmd/vendor/golang.org/x/arch/arm/arm64asm: TestObjdumpARM64TestDecode{GNU,Go}Syntaxdata FAIL Nov 3, 2018
@dmitshur
Copy link
Contributor

dmitshur commented Nov 3, 2018 •
edited

This might be related to #27754.

@dmitshur dmitshur added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Nov 4, 2018
@dmitshur dmitshur added this to the Go1.12 milestone Nov 4, 2018
@ianlancetaylor
Copy link
Contributor

I can't recreate this on tip; is this still a problem?

@ianlancetaylor ianlancetaylor added the WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided. label Dec 10, 2018
@zhangfannie
Copy link
Contributor

@cznic What version of objdump are you using? Because ext_test.go compares disassembly code decoded by the internal decoding and the external disassembler. The error you reported could not be reproduced on my machine. Maybe you need to use the right verison objdump.
The objudmp version I am using is (objdump -v):
GNU objdump (GNU Binutils) 2.29.1
Copyright (C) 2017 Free Software Foundation, Inc.
This program is free software; you may redistribute it under the terms of
the GNU General Public License version 3 or (at your option) any later version.
This program has absolutely no warranty.

@gopherbot
Copy link

Timed out in state WaitingForInfo. Closing.

(I am just a bot, though. Please speak up if this is a mistake or you have the requested information.)

@golang golang locked and limited conversation to collaborators Jan 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided.
Projects
None yet
Milestone
Go1.12
Development

No branches or pull requests
5 participants
@cznic @dmitshur @ianlancetaylor @gopherbot @zhangfannie