Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/compile/internal/gc: check Fatalf calls (no need to repeat "internal error") #28575

Closed
griesemer opened this issue Nov 3, 2018 · 2 comments
Closed

cmd/compile/internal/gc: check Fatalf calls (no need to repeat "internal error") #28575

griesemer opened this issue Nov 3, 2018 · 2 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Go1.12

Comments

@griesemer
Copy link
Contributor

griesemer commented Nov 3, 2018 •
edited

Fatalf already prints "internal compiler error". No need to repeat the "internal error" in the argument.

Also, there are a few log.Fatalf calls. Should use the usual gc mechanism there. (These are ok.)
@griesemer griesemer added the NeedsFix The path to resolution is known, but the work has not been done. label Nov 3, 2018
@griesemer griesemer added this to the Go1.12 milestone Nov 3, 2018
@griesemer griesemer self-assigned this Nov 3, 2018
@griesemer
Copy link
Contributor Author

Not urgent but simple cleanup anyway.

@gopherbot
Copy link

Change https://golang.org/cl/147287 mentions this issue: cmd/compile/internal/gc: don't print "internal error" twice

@golang golang locked and limited conversation to collaborators Nov 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Go1.12
Development

No branches or pull requests
2 participants
@griesemer @gopherbot