Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/go/analysis/passes/cgocall: test is failing #28566

Closed
alandonovan opened this issue Nov 2, 2018 · 2 comments
Closed

x/tools/go/analysis/passes/cgocall: test is failing #28566

alandonovan opened this issue Nov 2, 2018 · 2 comments
Labels
FrozenDueToAge
Milestone
Unreleased

Comments

@alandonovan
Copy link
Contributor

The cgocall test is (correctly) failing because the fragile findCall function has regressed due to changes in cmd.cgo. The test is temporarily suppressed to keep the build dashboard green.

Fix findCall, make it more robust, and re-enable the test.
@alandonovan alandonovan self-assigned this Nov 2, 2018
@gopherbot gopherbot added this to the Unreleased milestone Nov 2, 2018
@gopherbot
Copy link

Change https://golang.org/cl/147199 mentions this issue: go/analysis/passes/cgocall: disable test in go1.12

gopherbot pushed a commit to golang/tools that referenced this issue Nov 2, 2018
@adonovan
go/analysis/passes/cgocall: disable test in go1.12
c3ef14e 
The test correctly identified a problem.
Suppressing test to keep dashboard cleean, pending a fix.

Updates golang/go#28566

Change-Id: Ib3a8dbdd617c9f5701b5d6673434917d284dfb32
Reviewed-on: https://go-review.googlesource.com/c/147199
Run-TryBot: Alan Donovan <adonovan@google.com>
Reviewed-by: Michael Matloob <matloob@golang.org>
@gopherbot
Copy link

Change https://golang.org/cl/147317 mentions this issue: go/analysis/passes/cgocall: analyze raw cgo files (again)

@golang golang locked and limited conversation to collaborators Nov 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
2 participants
@alandonovan @gopherbot