Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build/cmd/gopherbot: duplicate github comments mentioning CLs #28561

Closed
bradfitz opened this issue Nov 2, 2018 · 1 comment
Closed

x/build/cmd/gopherbot: duplicate github comments mentioning CLs #28561

bradfitz opened this issue Nov 2, 2018 · 1 comment
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unreleased

Comments

@bradfitz
Copy link
Contributor

bradfitz commented Nov 2, 2018

#28434 (comment) has duplicate comments:

Change https://golang.org/cl/147117 mentions this issue: syscall: add Syscall18 on Windows

Change https://golang.org/cl/147117 mentions this issue: syscall: add Syscall18 on Windows

Change https://golang.org/cl/147117 mentions this issue: syscall: add Syscall18 on Windows

/cc @andybons @katiehockman @dmitshur
@bradfitz bradfitz added the NeedsFix The path to resolution is known, but the work has not been done. label Nov 2, 2018
@gopherbot gopherbot added this to the Unreleased milestone Nov 2, 2018
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Nov 2, 2018
@dmitshur
Copy link
Contributor

dmitshur commented Nov 2, 2018 •
edited

GitHub was having issues today according to https://status.github.com/messages:

image

As long as it's not causing significant problems and doesn't happen too often, it's out of scope for us to make gopherbot behave well during a GitHub API outage or partial outage. Closing because it's not a problem in gopherbot.

(If we need to address it in the future, a strategy to consider is to pause gopherbot when the GitHub Status API reports that GitHub API has issues.)

@dmitshur dmitshur closed this as completed Nov 2, 2018
@golang golang locked and limited conversation to collaborators Nov 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@bradfitz @dmitshur @gopherbot