Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go/scanner: API #2856

Closed
rsc opened this issue Feb 2, 2012 · 2 comments
Closed

go/scanner: API #2856

rsc opened this issue Feb 2, 2012 · 2 comments
Labels
FrozenDueToAge
Milestone
Go1

Comments

@rsc
Copy link
Contributor

rsc commented Feb 2, 2012 

The methods named Get* are not idiomatic.  

Error -> Add
GetError -> Error
GetErrorList -> ErrorList

?
@rsc
Copy link
Contributor Author

rsc commented Feb 2, 2012

Comment 1:

Also unidiomatic are the capitalized receiver names.

@griesemer
Copy link
Contributor

Comment 2:

This issue was closed by revision d08dd8b.

Status changed to Fixed.

@rsc rsc added fixed labels Feb 8, 2012
@rsc rsc added this to the Go1 milestone Apr 10, 2015
@golang golang locked and limited conversation to collaborators Jun 24, 2016
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Go1
Development

No branches or pull requests
3 participants
@rsc @griesemer @gopherbot