Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

misc/cgo/testsanitizers: TestTSAN fails in all.bash on release-branch.go1.10 #28542

Closed
bolyor opened this issue Nov 2, 2018 · 7 comments
Closed

misc/cgo/testsanitizers: TestTSAN fails in all.bash on release-branch.go1.10 #28542

bolyor opened this issue Nov 2, 2018 · 7 comments
Labels
FrozenDueToAge WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided.
Milestone
Go1.10.9

Comments

@bolyor
Copy link

bolyor commented Nov 2, 2018 •
edited by dmitshur

Please answer these questions before submitting your issue. Thanks!

What version of Go are you using (go version)?

go version go1.10.4 linux/amd64
branch: release-branch.go1.10

Does this issue reproduce with the latest release?

no

What operating system and processor architecture are you using (go env)?

GOARCH="amd64"
GOBIN=""
GOCACHE="/home/cenhong/.cache/go-build"
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/home/cenhong/codeclub"
GORACE=""
GOROOT="/home/cenhong/go1.10/go"
GOTMPDIR=""
GOTOOLDIR="/home/cenhong/go1.10/go/pkg/tool/linux_amd64"
GCCGO="gccgo"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build266575215=/tmp/go-build -gno-record-gcc-switches"

What did you do?

If possible, provide a recipe for reproducing the error.
A complete runnable program is good.
A link on play.golang.org is best.
git clone -b release-branch.go1.10 https://github.com/golang/go.git
cd go/src
./all.bash

What did you expect to see?

pass or success.

What did you see instead?

##### ../misc/cgo/testsanitizers
--- FAIL: TestTSAN (2.93s)
    --- FAIL: TestTSAN/tsan (0.48s)
        tsan_test.go:53: `/tmp/TestTSAN056529196/tsan` exited with signal: segmentation fault
    --- FAIL: TestTSAN/tsan2 (0.49s)
        tsan_test.go:53: `/tmp/TestTSAN576711846/tsan2` exited with signal: segmentation fault
    --- FAIL: TestTSAN/tsan8 (0.51s)
        tsan_test.go:53: `/tmp/TestTSAN538456995/tsan8` exited with signal: segmentation fault
    --- FAIL: TestTSAN/tsan3 (0.51s)
        tsan_test.go:53: `/tmp/TestTSAN355017865/tsan3` exited with signal: segmentation fault
    --- FAIL: TestTSAN/tsan4 (0.55s)
        tsan_test.go:53: `/tmp/TestTSAN249753406/tsan4` exited with signal: segmentation fault
    --- FAIL: TestTSAN/tsan9 (0.65s)
        tsan_test.go:53: `/tmp/TestTSAN715796991/tsan9` exited with signal: segmentation fault
FAIL
2018/11/02 17:46:18 Failed: exit status 1
@dmitshur dmitshur added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Nov 2, 2018
@dmitshur dmitshur added this to the Go1.10.5 milestone Nov 2, 2018
@dmitshur dmitshur changed the title FAIL: TestTSAN with all.bash on release-branch.go1.10 misc/cgo/testsanitizers: TestTSAN fails in all.bash on release-branch.go1.10 Nov 2, 2018
@dmitshur
Copy link
Contributor

dmitshur commented Nov 2, 2018 •
edited

Thanks for reporting. However, I can't reproduce this on linux/amd64 and latest release-branch.go1.10 commit 13a2f53. I got:

##### ../misc/cgo/testsanitizers
PASS

[...]

##### ../test

##### API check
Go version is "go1.10.4", ignoring -next /tmp/trygorb110/go/api/next.txt

ALL TESTS PASSED
---
Installed Go for linux/amd64 in /tmp/trygorb110/go
Installed commands in /tmp/trygorb110/go/bin
*** You need to add /tmp/trygorb110/go/bin to your PATH.

Which commit did you use? Can you try it again?

@dmitshur dmitshur added WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided. and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Nov 2, 2018
@dmitshur
Copy link
Contributor

dmitshur commented Nov 2, 2018

The test failure here looks very similar to #25601, which was for arm64, but still has very relevant information there.

@dmitshur
Copy link
Contributor

dmitshur commented Nov 2, 2018

This issue seems to be tied to a specific environment and gcc version, rather than being a regression on the release-branch.go1.10 branch. It's in WaitingForInfo state now, so moving to Go 1.10.6 milestone. /cc @andybons FYI.

@dmitshur dmitshur modified the milestones: Go1.10.5, Go1.10.6 Nov 2, 2018
@bolyor
Copy link
Author

bolyor commented Nov 7, 2018

@ git log:
commit 95b56b3
Author: Ian Lance Taylor iant@golang.org
Date: Fri Sep 7 04:12:42 2018 -0700

[release-branch.go1.10] cmd/go: add -Wl,--export-dynamic to linker flag whitelist

Fixes #27496

Change-Id: I53538c7697729294a9e50ace26a6a7183131e837
Reviewed-on: https://go-review.googlesource.com/134016
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Andrew Bonventre <andybons@golang.org>
(cherry picked from commit ceb7745cc846f798531ef019162dd9f1dabfea12)
Reviewed-on: https://go-review.googlesource.com/134135

@bolyor
Copy link
Author

bolyor commented Nov 7, 2018

I tried commit 1100df5 today, occured this problem again, I guess this bug is related to my personal env.

@bolyor
Copy link
Author

bolyor commented Nov 8, 2018

I changed my gcc version from 5.4 to 4.9.3, this issue was fixed. Thank you.

@dmitshur dmitshur modified the milestones: Go1.10.6, Go1.10.7 Dec 13, 2018
@FiloSottile FiloSottile modified the milestones: Go1.10.7, Go1.10.8 Dec 15, 2018
@julieqiu julieqiu modified the milestones: Go1.10.8, Go1.10.9 Jan 23, 2019
@andybons
Copy link
Member

With the release of 1.12, 1.10 is no longer supported so I am closing this issue. Thanks.

@golang golang locked and limited conversation to collaborators Mar 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided.
Projects
None yet
Milestone
Go1.10.9
Development

No branches or pull requests
6 participants
@andybons @FiloSottile @dmitshur @julieqiu @gopherbot @bolyor