Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

website: all examples on tip.golang.org cannot be run #28536

Closed
ysmolski opened this issue Nov 1, 2018 · 4 comments
Closed

website: all examples on tip.golang.org cannot be run #28536

ysmolski opened this issue Nov 1, 2018 · 4 comments
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.

Comments

@ysmolski
Copy link
Member

ysmolski commented Nov 1, 2018 •
edited

I expected to be able to run examples on tip.golang.org. But all of them are not runnable.

I'd like to see how changes in /x/tools/godoc and in go/doc affect the website before deploying (releasing) new version of go.
@gopherbot
Copy link

Change https://golang.org/cl/146917 mentions this issue: cmd/tip: enable playground on tip.golang.org

gopherbot pushed a commit to golang/tools that referenced this issue Nov 2, 2018
@agnivade @bradfitz
cmd/tip: enable playground on tip.golang.org
92b943e 
Updates golang/go#28536

Change-Id: I3ece72aacd4635f4580be404672394a47791a1e8
Reviewed-on: https://go-review.googlesource.com/c/146917
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
@bradfitz bradfitz added Builders x/build issues (builders, bots, dashboards) NeedsFix The path to resolution is known, but the work has not been done. labels Nov 2, 2018
@bradfitz
Copy link
Contributor

bradfitz commented Nov 2, 2018

I approved & submitted the CL, but this also needs to be deployed.

@dmitshur?

@agnivade
Copy link
Contributor

As I understand, tip gets auto-redeployed every few minutes. So playground is already enabled now. Is there anything pending here ?

@ysmolski
Copy link
Member Author

I created this when I was fixing this example https://tip.golang.org/pkg/image/png/#example_Decode
Example can be played and fix works, so I consider this done too.

@golang golang locked and limited conversation to collaborators Jan 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@bradfitz @ysmolski @agnivade @dmitshur @gopherbot