Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build/cmd/gopherbot: wait-author tag not being auto-removed from updated CLs #28510

Closed
bradfitz opened this issue Oct 31, 2018 · 6 comments
Closed
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone

Comments

@bradfitz
Copy link
Contributor

Gopherbot is supposed to be removing the wait-author tag on CLs when an OP replies or updates a new patchset.

I've noticed it hasn't been. Here's an example:

https://go-review.googlesource.com/c/go/+/142537

I added the tag at https://go-review.googlesource.com/c/go/+/142537#message-38fe2a310757d0fde272356e560843068aa980c3 and then PS2 was uploaded, but the wait-author tag remains.

/cc @dmitshur @katiehockman @bcmills

@bradfitz bradfitz added the NeedsFix The path to resolution is known, but the work has not been done. label Oct 31, 2018
@gopherbot gopherbot added this to the Unreleased milestone Oct 31, 2018
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Oct 31, 2018
@dmitshur
Copy link
Contributor

dmitshur commented Oct 31, 2018

This is likely caused by issue #28318.

If you do go run golang.org/x/build/maintner/cmd/maintserve -http=localhost:8080, then visit http://localhost:8080/go.googlesource.com/go and search for "#142537", you'll see that maintner reports that CL as not having any tags:

image

As a result, gopherbot doesn't believe that the CL has a wait-author tag, so it doesn't try to remove it.

@dmitshur
Copy link
Contributor

dmitshur commented Oct 31, 2018

A simple program that confirms it:

package main

import (
	"context"
	"fmt"
	"log"

	"golang.org/x/build/maintner/godata"
)

func main() {
	corpus, err := godata.Get(context.Background())
	if err != nil {
		log.Fatalln(err)
	}
	cl := corpus.Gerrit().Project("go.googlesource.com", "go").CL(142537)
	fmt.Printf("tags = %q\n", cl.Meta.Hashtags())

	// Output:
	// tags = ""
}

@Skarlso
Copy link
Contributor

Skarlso commented Nov 15, 2018

Note here too. I volunteered for the fix of the corresponding issue #25253.

@Skarlso
Copy link
Contributor

Skarlso commented Nov 17, 2018

Tags are now correctly displayed on a local test run:

screenshot 2018-11-17 at 21 01 43

And the linked issue:

screenshot 2018-11-17 at 21 05 40

screenshot 2018-11-17 at 21 04 12

@gopherbot
Copy link

Change https://golang.org/cl/152779 mentions this issue: maintner: fix GerritMeta.Hashtags to look at earlier meta parents for answer

gopherbot pushed a commit to golang/build that referenced this issue Dec 7, 2018
… answer

The Gerrit meta commit graph is a linear history. The most recent meta
with a "Hashtags: " footer line has the complete set. We just have to
go back and look for it.

Fixes golang/go#28318
Updates golang/go#28510 (fixes after gopherbot re-deployed)
Updates golang/go#28320 (fixes after gopherbot re-deployed)

Change-Id: I43705075800ae3d353c1c8f60ab7685883ea5602
Reviewed-on: https://go-review.googlesource.com/c/152779
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
@bradfitz
Copy link
Contributor Author

gopherbot was re-deployed with the maintner fix.

@golang golang locked and limited conversation to collaborators Dec 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Development

No branches or pull requests

4 participants