New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/build/cmd/gopherbot: wait-author tag not being auto-removed from updated CLs #28510
Comments
This is likely caused by issue #28318. If you do As a result, |
A simple program that confirms it: package main
import (
"context"
"fmt"
"log"
"golang.org/x/build/maintner/godata"
)
func main() {
corpus, err := godata.Get(context.Background())
if err != nil {
log.Fatalln(err)
}
cl := corpus.Gerrit().Project("go.googlesource.com", "go").CL(142537)
fmt.Printf("tags = %q\n", cl.Meta.Hashtags())
// Output:
// tags = ""
} |
Note here too. I volunteered for the fix of the corresponding issue #25253. |
Change https://golang.org/cl/152779 mentions this issue: |
… answer The Gerrit meta commit graph is a linear history. The most recent meta with a "Hashtags: " footer line has the complete set. We just have to go back and look for it. Fixes golang/go#28318 Updates golang/go#28510 (fixes after gopherbot re-deployed) Updates golang/go#28320 (fixes after gopherbot re-deployed) Change-Id: I43705075800ae3d353c1c8f60ab7685883ea5602 Reviewed-on: https://go-review.googlesource.com/c/152779 Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
gopherbot was re-deployed with the maintner fix. |
Gopherbot is supposed to be removing the wait-author tag on CLs when an OP replies or updates a new patchset.
I've noticed it hasn't been. Here's an example:
https://go-review.googlesource.com/c/go/+/142537
I added the tag at https://go-review.googlesource.com/c/go/+/142537#message-38fe2a310757d0fde272356e560843068aa980c3 and then PS2 was uploaded, but the wait-author tag remains.
/cc @dmitshur @katiehockman @bcmills
The text was updated successfully, but these errors were encountered: