x/build: NaN values cause panics at the trend handler for perf.golang.org #28508
Labels
Builders
x/build issues (builders, bots, dashboards)
compiler/runtime
Issues related to the Go compiler and/or runtime.
FrozenDueToAge
NeedsInvestigation
Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Please answer these questions before submitting your issue. Thanks!
What version of Go are you using (
go version
)?go1.11.1
Does this issue reproduce with the latest release?
yes, it does
What operating system and processor architecture are you using (
go env
)?darwin/amd64
What did you do?
Using the localperf cmd (golang.org/x/perf/analysis/localperf) when I tried to check the trends over the last commits, the server crashed with this panic message:
It happens when the sets of benchmarks have different tests (benchmarks added or removed).
The easiest way to reproduce it is by extending the test
golang.org/x/perf/analysis/app/trend_test.go
What did you expect to see?
I guess a
nil
value could be okWhat did you see instead?
A panic
Comments
By the way, this dirty hack fixed the issue:
The text was updated successfully, but these errors were encountered: