Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go/doc: synthesised example does not import all the packages #28492

Closed
ysmolski opened this issue Oct 30, 2018 · 1 comment
Closed

go/doc: synthesised example does not import all the packages #28492

ysmolski opened this issue Oct 30, 2018 · 1 comment
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Go1.12

Comments

@ysmolski
Copy link
Member

ysmolski commented Oct 30, 2018 •
edited

This example is broken https://golang.org/pkg/image/png/#example_Decode. It should have the io package imported. As result, the example cannot be run.

It looks like bug happens in theplayExample function. It does not inspect the return type io.Reader of the gopherPNG function. I am about to submit a patch.
@ysmolski ysmolski added the NeedsFix The path to resolution is known, but the work has not been done. label Oct 30, 2018
@ysmolski ysmolski added this to the Go1.12 milestone Oct 30, 2018
@gopherbot
Copy link

Change https://golang.org/cl/146118 mentions this issue: go/doc: inspect result types when synthesising playground examples

@ysmolski ysmolski self-assigned this Oct 31, 2018
@ghost ghost mentioned this issue Nov 1, 2018
Closed
@golang golang locked and limited conversation to collaborators Nov 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Go1.12
Development

No branches or pull requests
2 participants
@ysmolski @gopherbot