Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto/tls: timeouts in test broke arm5 builder #28405

Closed
bradfitz opened this issue Oct 26, 2018 · 3 comments
Closed

crypto/tls: timeouts in test broke arm5 builder #28405

bradfitz opened this issue Oct 26, 2018 · 3 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Soon This needs to be done soon. (regressions, serious bugs, outages) Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Go1.12

Comments

@bradfitz
Copy link
Contributor

The arm5 builder is really slow.

These new test timeouts were too much:
https://go-review.googlesource.com/c/go/+/144116

Breakage:
https://build.golang.org/log/1d714db6c446f94662c31179523d92f0de2f3665

ok  	crypto/subtle	0.062s
--- FAIL: TestClientAuth (1.52s)
    handshake_server_test.go:626: TLSv12-ClientAuthRequestedAndECDSAGiven #4: read tcp 127.0.0.1:57366->127.0.0.1:39527: i/o timeout
        Read 0, wanted 144, got , wanted 14030300010116030300400000000000000000000000000000000013c4d23fb084083274decce097908ac6cc9487ac4865f72004184268468ec019b69d2a84588520b3ed7594714e5b0ade170303004000000000000000000000000000000000c26ec5134d35abb1dee21ba66f0e4064cc67bf0db1e4fe48c401356a9450177ab36bf66b2a24c9b97bb0420e714dc2da
--- FAIL: TestHandshakeClientECDHEECDSAChaCha20 (1.00s)
    handshake_client_test.go:395: TLSv12-ECDHE-ECDSA-CHACHA20-POLY1305 #2: read tcp 127.0.0.1:39527->127.0.0.1:57432: i/o timeout
--- FAIL: TestHandshakeClientCertRSA (1.22s)
    handshake_client_test.go:395: TLSv10-ClientCert-RSA-ECDSA #2: read tcp 127.0.0.1:39527->127.0.0.1:57436: i/o timeout
--- FAIL: TestHandshakeClientECDHEECDSAAESGCM (1.06s)
    handshake_client_test.go:395: TLSv12-ECDHE-ECDSA-AES-GCM #2: read tcp 127.0.0.1:39527->127.0.0.1:57448: i/o timeout
--- FAIL: TestHandshakeClientECDHEECDSAAES128CBCSHA256 (1.05s)
    handshake_client_test.go:395: TLSv12-ECDHE-ECDSA-AES128-SHA256 #2: read tcp 127.0.0.1:39527->127.0.0.1:57450: i/o timeout
--- FAIL: TestHandshakeClientCertECDSA (3.10s)
    handshake_client_test.go:395: TLSv10-ClientCert-ECDSA-ECDSA #2: read tcp 127.0.0.1:39527->127.0.0.1:57454: i/o timeout
--- FAIL: TestHandshakeClientAES256GCMSHA384 (1.02s)
    handshake_client_test.go:395: TLSv12-ECDHE-ECDSA-AES256-GCM-SHA384 #2: read tcp 127.0.0.1:39527->127.0.0.1:57464: i/o timeout
--- FAIL: TestHandshakeClientECDHEECDSAAES (1.02s)
    handshake_client_test.go:395: TLSv10-ECDHE-ECDSA-AES #2: read tcp 127.0.0.1:39527->127.0.0.1:57474: i/o timeout
FAIL
FAIL	crypto/tls	24.738s
@bradfitz bradfitz added Testing An issue that has been verified to require only test changes, not just a test failure. NeedsFix The path to resolution is known, but the work has not been done. Soon This needs to be done soon. (regressions, serious bugs, outages) labels Oct 26, 2018
@bradfitz bradfitz added this to the Go1.12 milestone Oct 26, 2018
@bradfitz
Copy link
Contributor Author

Also broke mips, which is also slow:
https://build.golang.org/log/1d714db6c446f94662c31179523d92f0de2f3665

@FiloSottile
Copy link
Contributor

Wow, that's slower than I thought computers could go. I'll bump it to a minute, less useful but still better than a test timeout.

@gopherbot
Copy link

Change https://golang.org/cl/145037 mentions this issue: crypto/tls: bump test timeouts from 1s to 1m for slow builders

@golang golang locked and limited conversation to collaborators Oct 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Soon This needs to be done soon. (regressions, serious bugs, outages) Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Go1.12
Development

No branches or pull requests
3 participants
@bradfitz @FiloSottile @gopherbot