@bcmills

@gopherbot needsinvestigation modules

@karysto taking your example; given child_repo is a module, then its dependencies (including grandchild_repo) will not appear in parent_repo. The dependency relationship still exists: go list -m all will show you all your dependencies in case you need to see that list.

This is working as intended.

@myitcv thanks for taking a look. If the required dependencies (in this case grandchild_repo) aren't put into in go.mod by go mod tidy, then go build fails. Is there a workflow or tool I'm missing that automates adding these sub-dependencies to go.mod to allow the build to succeed?

@karysto sorry for just a quick comment, but does it seem like #26241 might be related?

Also, would you be able to put together 3 or so short but representative go.mod files that capture the essence of what you are seeing?

(A full blown repository on github that shows what you are seeing would be even better, but maybe to start some sample go.mod files could help make the nature of the problem more concrete).

@karysto If you're seeing a build failure then there is something else going on, because grandchild should not be required in the parent's go.mod:

$ cd $(mktemp -d)
$ mkdir parent child grandchild
$ pushd grandchild
/tmp/tmp.VJ58bS5pTj/grandchild /tmp/tmp.VJ58bS5pTj
$ go mod init example.com/grandchild
go: creating new go.mod: module example.com/grandchild
$ cat <<EOD >main.go
package grandchild

func Count() int {
        return 5
}
EOD
$ go mod tidy
$ popd
/tmp/tmp.VJ58bS5pTj
$ pushd child
/tmp/tmp.VJ58bS5pTj/child /tmp/tmp.VJ58bS5pTj
$ go mod init example.com/child
go: creating new go.mod: module example.com/child
$ cat <<EOD >main.go
package child

import "example.com/grandchild"

func Children() int {
        return grandchild.Count()
}
EOD
$ go mod edit -require=example.com/grandchild@v0.0.0 -replace=example.com/grandchild=$PWD/../grandchild
$ go mod tidy
$ cat go.mod
module example.com/child

require example.com/grandchild v0.0.0

replace example.com/grandchild => /tmp/tmp.VJ58bS5pTj/child/../grandchild
$ popd
/tmp/tmp.VJ58bS5pTj
$ pushd parent
/tmp/tmp.VJ58bS5pTj/parent /tmp/tmp.VJ58bS5pTj
$ go mod init example.com/parent
go: creating new go.mod: module example.com/parent
$ cat <<EOD >main.go
package main

import (
        "example.com/child"
        "fmt"
)

func main() {
        fmt.Printf("My child has %[1]v children; hence I have %[1]v grand children\n", child.Children())
}
EOD
$ go mod edit -require=example.com/child@v0.0.0 -replace=example.com/grandchild=$PWD/../grandchild -replace=example.com/child=$PWD/../child
$ go mod tidy
$ cat go.mod
module example.com/parent

require example.com/child v0.0.0

replace example.com/grandchild => /tmp/tmp.VJ58bS5pTj/parent/../grandchild

replace example.com/child => /tmp/tmp.VJ58bS5pTj/parent/../child
$ go run .
My child has 5 children; hence I have 5 grand children

Notice I'm using replace directives here (per @thepudds' comment above) because I haven't published the dependencies. Hence I do need a replace for grandchild until I do publish them, but not a require.

@thepudds thanks for the response, I'll setup a repo demonstrating the issue so that it can be reproduced.

@myitcv I agree, grandchild_repo should not be needed, but for some reason the build fails if it's not included in the parent_repo go.mod. I have the set of replace directives for the local dependencies in the go.mod as well, the issue persists despite them. Do you have an idea of what other possible issue this could be related to that I might be missing?

@karysto

Do you have an idea of what other possible issue this could be related to that I might be missing?

Not without a repro, no.