Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compress/gzip: API #2839

Closed
rsc opened this issue Feb 2, 2012 · 3 comments
Closed

compress/gzip: API #2839

rsc opened this issue Feb 2, 2012 · 3 comments
Labels
FrozenDueToAge
Milestone
Go1

Comments

@rsc
Copy link
Contributor

rsc commented Feb 2, 2012 

I can't imagine what error NewWriter could return.
It should probably not return one.

The doc comment on Decompressor talks about receiving
a (zero, nil) from Read.  Surely it means (0, io.EOF).
@rsc
Copy link
Contributor Author

rsc commented Feb 2, 2012

Comment 1:

Also, the BUGS section talks about non-UTF-8 names not mapping properly.  Instead of
saying "don't properly map" it should say what they do.  For example (if this is true)
The Comment and Name header fields are UTF-8 strings, but the underlying storage uses
Latin-1.  Non-Latin-1 characters in the strings are stored as ? characters.

@nigeltao
Copy link
Contributor

nigeltao commented Feb 8, 2012

Comment 2:

Owner changed to @nigeltao.

@nigeltao
Copy link
Contributor

Comment 3:

This issue was closed by revision cc9ed44.

Status changed to Fixed.

@rsc rsc added fixed labels Feb 10, 2012
@rsc rsc added this to the Go1 milestone Apr 10, 2015
@golang golang locked and limited conversation to collaborators Jun 24, 2016
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Go1
Development

No branches or pull requests
3 participants
@rsc @nigeltao @gopherbot