Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

misc: add tests to work with modules #28361

Closed
hyangah opened this issue Oct 24, 2018 · 2 comments
Closed

misc: add tests to work with modules #28361

hyangah opened this issue Oct 24, 2018 · 2 comments
Labels
FrozenDueToAge modules

Comments

@hyangah
Copy link
Contributor

hyangah commented Oct 24, 2018

Many tests in misc, particularly various tests in misc/cgo/* including testing various buildmodes are written to work in GOPATH. Add tests to exercise the logic for module support.
@dmitshur
Copy link
Contributor

/cc @bcmills I think you may have addressed this fully or partially during the Go 1.13 dev cycle. Please see if this issue needs to be updated.

@bcmills
Copy link
Contributor

bcmills commented Apr 18, 2019

All of the misc tests now run in module mode. (They should still pass in GOPATH mode too, but they're running in module mode by default.)

@bcmills bcmills closed this as completed Apr 18, 2019
@golang golang locked and limited conversation to collaborators Apr 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge modules
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@dmitshur @hyangah @bcmills @gopherbot