Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bufio: API #2836

Closed
rsc opened this issue Feb 2, 2012 · 3 comments
Closed

bufio: API #2836

rsc opened this issue Feb 2, 2012 · 3 comments
Labels
FrozenDueToAge
Milestone
Go1

Comments

@rsc
Copy link
Contributor

rsc commented Feb 2, 2012 

The special Error type can be deleted in favor of errors.New.

ReadRune should document its behavior on invalid input.

BufsizeError should probably go away; make NewReaderSize
and NewWriterSize panic if the buffer size is too small, or else
make them round up to the minimum buffer size.

Should document that write errors in bufio.Writer are sticky.
@robpike
Copy link
Contributor

robpike commented Feb 7, 2012

Comment 1:

There is an issue with eliminating BufSizeError: the associated routines will always
return nil for an error.
I favor rounding up to the minimum size, and documenting that the error is always nil,
for historical reasons. I could also see gofixing away the error return.

@robpike
Copy link
Contributor

robpike commented Feb 8, 2012

Comment 2:

Owner changed to @robpike.

Status changed to Started.

@robpike
Copy link
Contributor

robpike commented Feb 8, 2012

Comment 3:

This issue was closed by revision bb7b1a1.

Status changed to Fixed.

@rsc rsc added fixed labels Feb 8, 2012
@rsc rsc added this to the Go1 milestone Apr 10, 2015
@golang golang locked and limited conversation to collaborators Jun 24, 2016
@rsc rsc unassigned robpike Jun 22, 2022
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Go1
Development

No branches or pull requests
3 participants
@rsc @robpike @gopherbot