Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spec: don't use "exception" instead of "panic" #28341

Closed
ainar-g opened this issue Oct 23, 2018 · 1 comment
Closed

spec: don't use "exception" instead of "panic" #28341

ainar-g opened this issue Oct 23, 2018 · 1 comment
Labels
Documentation Issues describing a change to documentation. FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone

Comments

@ainar-g
Copy link
Contributor

ainar-g commented Oct 23, 2018

When the Spec talks about integer overflow, there is this sentence:

(…) No exception is raised as a result of overflow. (…)

Emphasis added. Go doesn't have exceptions, it has panics. I think this sentence should be rewritten to something like:

(…) Overflow does not trigger a run-time panic. (…)

As far as I can see, the word "exception" meaning "run-time error" isn't used anywhere else in the Spec.

@ianlancetaylor ianlancetaylor added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Oct 23, 2018
@ianlancetaylor ianlancetaylor added this to the Go1.12 milestone Oct 23, 2018
@ianlancetaylor ianlancetaylor added the Documentation Issues describing a change to documentation. label Oct 23, 2018
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/144260 mentions this issue: spec: refer to "run-time panic" rather than "execption" (cleanup)

@griesemer griesemer added NeedsFix The path to resolution is known, but the work has not been done. and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Oct 23, 2018
@golang golang locked and limited conversation to collaborators Oct 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Documentation Issues describing a change to documentation. FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Development

No branches or pull requests

4 participants