Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

encoding/gob: test suite now apparently requires >8GB of RAM #28321

Closed
ALTree opened this issue Oct 22, 2018 · 1 comment
Closed

encoding/gob: test suite now apparently requires >8GB of RAM #28321

ALTree opened this issue Oct 22, 2018 · 1 comment
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone

Comments

@ALTree
Copy link
Member

ALTree commented Oct 22, 2018

Since CL 143678 (encoding/gob: increase "tooBig" from 1GB to 8GB on 64-bit machines), I'm no longer able to run the encoding/gob test suite on my machine (with 8GB of RAM). Running the tests kills my OS.

The longtest builder is also failing, presumably for the same reason:
https://build.golang.org/log/ffd8eaed071a4dae7d1af28735e9b9c1bc42a2be

The tests should probably be tuned so that they don't require >8GB of RAM to be run.

cc @robpike

@ALTree ALTree added the Testing An issue that has been verified to require only test changes, not just a test failure. label Oct 22, 2018
@ALTree ALTree added this to the Go1.12 milestone Oct 22, 2018
@ALTree ALTree changed the title encoding/gob: test suite now apparently require >8GB of RAM encoding/gob: test suite now apparently requires >8GB of RAM Oct 22, 2018
@ALTree ALTree added the NeedsFix The path to resolution is known, but the work has not been done. label Oct 22, 2018
@robpike robpike self-assigned this Oct 22, 2018
@gopherbot
Copy link

Change https://golang.org/cl/143817 mentions this issue: encoding/gob: delete out of memory test

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Development

No branches or pull requests

3 participants