New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/build/cmd/gopherbot: keeps repeating some actions without effect #28320
Comments
Change https://golang.org/cl/152779 mentions this issue: |
… answer The Gerrit meta commit graph is a linear history. The most recent meta with a "Hashtags: " footer line has the complete set. We just have to go back and look for it. Fixes golang/go#28318 Updates golang/go#28510 (fixes after gopherbot re-deployed) Updates golang/go#28320 (fixes after gopherbot re-deployed) Change-Id: I43705075800ae3d353c1c8f60ab7685883ea5602 Reviewed-on: https://go-review.googlesource.com/c/152779 Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
There's a new addition, as of #30182:
To fix the endless freezing of an issue that's 404, we'll need to update |
The current state as of September 2019:
|
Change https://golang.org/cl/195062 mentions this issue: |
Change https://golang.org/cl/176038 mentions this issue: |
Updates golang/go#22635 Updates golang/go#28320 Change-Id: I8769dc83187ad1b1b2c1d751818964565f34e6d3 Reviewed-on: https://go-review.googlesource.com/c/build/+/176038 Run-TryBot: Andrew Bonventre <andybons@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
This is a cherry-pick of CL 135456 that restores Gerrit emails for some people that were incorrectly changed in CL 165639, with manual no-op addPerson line merges to address code review comments. The cherry-pick applied very cleanly with just two minor merge conflicts: one due to a Filippo's email already being fixed in CL 176037, and another due to a close new entry. Add tests to catch this from happening again, until the source of the problem is resolved in issue golang/go#34259. Updates golang/go#34259 Updates golang/go#28320 Updates golang/go#31919 Updates golang/go#27517 Updates golang/go#27631 Change-Id: Ia03a2b94403334d3f571ac5623e12d3bfd6f1e4f Reviewed-on: https://go-review.googlesource.com/c/build/+/195062 Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Updates golang/go#22635 Updates golang/go#28320 Change-Id: I8769dc83187ad1b1b2c1d751818964565f34e6d3 Reviewed-on: https://go-review.googlesource.com/c/build/+/176038 Run-TryBot: Andrew Bonventre <andybons@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
This is a cherry-pick of CL 135456 that restores Gerrit emails for some people that were incorrectly changed in CL 165639, with manual no-op addPerson line merges to address code review comments. The cherry-pick applied very cleanly with just two minor merge conflicts: one due to a Filippo's email already being fixed in CL 176037, and another due to a close new entry. Add tests to catch this from happening again, until the source of the problem is resolved in issue golang/go#34259. Updates golang/go#34259 Updates golang/go#28320 Updates golang/go#31919 Updates golang/go#27517 Updates golang/go#27631 Change-Id: Ia03a2b94403334d3f571ac5623e12d3bfd6f1e4f Reviewed-on: https://go-review.googlesource.com/c/build/+/195062 Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Change https://golang.org/cl/308790 mentions this issue: |
A good amount of time has passed since the deletedIssues map was last updated, and the "freeze old issues" task was needlessly making 34 API calls to freeze issues that are gone. After this change, that task is making 0 API calls (whenever there aren't existing issues to freeze). Some gardening tasks were converted to be more general and run on more issue trackers in CL 233377, so update the deletedIssues map to track the repo ID in addition to the issue number. For golang/go#28320. Updates golang/go#22635. Updates golang/go#44406. Updates golang/go#39008. Change-Id: I3b477bf717f7d97676e9ef950214a3598ec3abd2 Reviewed-on: https://go-review.googlesource.com/c/build/+/308790 Trust: Dmitri Shuralyov <dmitshur@golang.org> Reviewed-by: Carlos Amedee <carlos@golang.org>
Change https://go.dev/cl/386754 mentions this issue: |
Owners may include users that do not have an associated Gerrit account, notably GitHub Teams. When determining reviewers to add a CL, drop all these users from the potential reviewer set. Otherwise Gerrit chokes on attempting to set reviewer to "". Dropping these users from owners may result in an empty primary reviewer set (e.g., on packages where a GitHub team is the only primary owner). In this case, upgrade the secondary owners to primary so they end up as reviewers rather than just CC'd. If both lists are empty, a 'no-owners' tag is added to the CL by assignReviewersToCLs. For golang/go#50723. For golang/go#28320. Change-Id: I99ac5426e080bf32c46817c09debeac507282e01 Reviewed-on: https://go-review.googlesource.com/c/build/+/386754 Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org> Trust: Michael Pratt <mpratt@google.com> Run-TryBot: Michael Pratt <mpratt@google.com> TryBot-Result: Gopher Robot <gobot@golang.org>
Change https://go.dev/cl/397634 mentions this issue: |
Change https://go.dev/cl/397635 mentions this issue: |
Issues that are gone don't come back. When gopherbot encounters such issues, it might as well remember it for the next iteration. This change makes it so that repeating actions without effect happen once per gopherbot startup, rather than on each iteration. This is to reduce needless GitHub API quota consumption. Also update the initial deletedIssues value with newly gone issues. For golang/go#28320. Updates golang/go#40640. Change-Id: I36f3cb780c96ac407482d6c40b4c3e935286e10b Reviewed-on: https://go-review.googlesource.com/c/build/+/397634 Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Heschi Kreinick <heschi@google.com> Trust: Dmitri Shuralyov <dmitshur@golang.org> Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
The maintner Go corpus makes all issues available to its caller, including those that are gone, are Pull Requests, are closed, and so on. Most of gopherbot tasks operate on open non-PR issues that aren't gone, and need to filter out non-actionable issues. Create a wrapper that adapts maintner's ForeachIssue API for the needs of gopherbot, so the code checking an issue's NotExist field or presence in deletedIssues map doesn't need to be copied in each task. Tested by running gopherbot in dry-run mode. It didn't try to take any unexpected actions. For golang/go#28320. Updates golang/go#40640. Change-Id: Icf235d046df5d371217ea14f86911ed7a39e6a3f Reviewed-on: https://go-review.googlesource.com/c/build/+/397635 Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org> Trust: Dmitri Shuralyov <dmitshur@golang.org> Reviewed-by: Heschi Kreinick <heschi@google.com> TryBot-Result: Gopher Robot <gobot@golang.org>
Change https://go.dev/cl/442156 mentions this issue: |
The deleted issue 55403 wasn't being detected as deleted and causing errors. Add a little logic to handle this category of deleted issues. For golang/go#28320. Updates golang/go#30184. Change-Id: I37f06a1330b6993e5526ea196074102c96fe98f9 Reviewed-on: https://go-review.googlesource.com/c/build/+/442156 Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org> Reviewed-by: Carlos Amedee <carlos@golang.org> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
Change https://go.dev/cl/502855 mentions this issue: |
Gopherbot fails to add the previous email as a reviewer because it's not associated with any Gerrit account anymore. Update it to the one reported by 'curl https://go-review.googlesource.com/accounts/13437'. Also merge the two addPerson calls into one while here. For golang/go#28320. Change-Id: If2ee53299d9f54eb1d1d3e8609e7c92ff705f91e Reviewed-on: https://go-review.googlesource.com/c/build/+/502855 Reviewed-by: Heschi Kreinick <heschi@google.com> Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org> Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
I noticed this in the gopherbot logs recently, and it's possible to reproduce locally in dry-run mode. Gopherbot keeps on repeating some actions every iteration. These actions don't have an effect, and so gopherbot never stops repeating them.
Reproduce Steps
It's pretty harmless, but would be nice to fix.
The underlying issues causing this are:
Fixing those issues should resolve this issue.
/cc @bradfitz @andybons
The text was updated successfully, but these errors were encountered: